Skip to content

CLI-723 Cleanup legacy resources unconditionally to support downgrades#492

Merged
georgii-borovinskikh-sonarsource merged 1 commit into
masterfrom
gb/fix-hook-migration
Jun 19, 2026
Merged

CLI-723 Cleanup legacy resources unconditionally to support downgrades#492
georgii-borovinskikh-sonarsource merged 1 commit into
masterfrom
gb/fix-hook-migration

Conversation

@georgii-borovinskikh-sonarsource

@georgii-borovinskikh-sonarsource georgii-borovinskikh-sonarsource commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Part of CLI-505


Summary by Gitar

  • Integration cleanup logic:
    • Modified IntegrationInstaller to invoke cleanupRecordedLegacyInstallations unconditionally before processing resources.
    • This ensures legacy resources are removed even if the current state records a newer version, supporting downgrade scenarios.
  • Testing:
    • Added a unit test in registry.test.ts to verify that legacy cleanups execute during re-installation after a file state reversion.

This will update automatically on new commits.

@netlify

netlify Bot commented Jun 19, 2026

Copy link
Copy Markdown

Deploy Preview for sonarqube-cli canceled.

Name Link
🔨 Latest commit 5cf7f77
🔍 Latest deploy log https://app.netlify.com/projects/sonarqube-cli/deploys/6a353d3e77a2fa0008795640

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod Bot changed the title Cleanup legacy resources unconditionally to support downgrades CLI-723 Cleanup legacy resources unconditionally to support downgrades Jun 19, 2026
@hashicorp-vault-sonar-prod

hashicorp-vault-sonar-prod Bot commented Jun 19, 2026

Copy link
Copy Markdown

CLI-723

@gitar-bot

gitar-bot Bot commented Jun 19, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Modifies the integration installer to perform unconditional cleanup of legacy resources, ensuring proper environment state during version downgrades. No issues found.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@tomshafir-sonarsource tomshafir-sonarsource left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarqubecloud

Copy link
Copy Markdown

@georgii-borovinskikh-sonarsource georgii-borovinskikh-sonarsource merged commit cace896 into master Jun 19, 2026
22 checks passed
@georgii-borovinskikh-sonarsource georgii-borovinskikh-sonarsource deleted the gb/fix-hook-migration branch June 19, 2026 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants