SC-50740 Implement agentic-readiness tools#460
Conversation
90edfce to
33fcb52
Compare
33fcb52 to
a8c48e7
Compare
a8c48e7 to
8fbc311
Compare
nquinquenel
left a comment
There was a problem hiding this comment.
Overall it's looking good, some comments though.
7ac3469 to
ed9c1ab
Compare
nquinquenel
left a comment
There was a problem hiding this comment.
Looks good, just some comments about consistency with the codebase and how we do things. Please use a xxToolResponse object per tool, with concise description of each field (it's per the MCP recommendations).
We have a test tool_names_should_be_descriptive that verifies tool naming. It's not effective in your case because the tools are not in the test path. However it'd be great to add start as part of the allowed keywords, matching your tool
8682692 to
6794a35
Compare
nquinquenel
left a comment
There was a problem hiding this comment.
LGTM! 2 small comments
Thanks for contributing to the MCP :)
5a3606d to
68fd1a3
Compare
|
Code Review ✅ Approved 6 resolved / 6 findingsImplements agentic-readiness MCP tools gated by feature flags, including assessment lifecycle management and API integration. Resolved issues regarding inconsistent SARA readiness level scales and potential NullPointerExceptions in assessment signals. ✅ 6 resolved✅ Quality: SARA readiness level scale is inconsistent and has duplicate text
✅ Edge Case: Removed null guard on SubSignal.evidence() risks NPE
✅ Quality: Start assessment tool marked read-only but creates a resource
✅ Quality: Inconsistent & duplicated SARA readiness level scale
✅ Quality: Duplicate L4/L5 readiness-level descriptions in SARA instructions
...and 1 more resolved from earlier reviews OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |



This PR introduces tools for agentic-readiness private beta feature under the flag.
start_agentic_readiness_assessmentget_agentic_readiness_assessmentlist_agentic_readiness_assessmentsValidated on dev12 environment:
Flag on:

Flag off:

Tools in CLI:



Example of execution with simple prompt:

Summary by Gitar
AgenticReadinessApito interact with WaS experiment endpoints.WasFeatureFlagsApito verify SARA feature flag status for organizations.StartAgenticReadinessAssessmentTool,GetAgenticReadinessAssessmentTool, andListAgenticReadinessAssessmentsTool.AGENTIC_READINESStoToolCategoryand implemented tool registration logic gated by feature flags.ProjectBranchesApiwithgetProjectUuidto support assessment operations.MockWebServerstubbing capabilities to properly resolve URL paths for testing.GetAgenticReadinessAssessmentToolTestsand related test suites.This will update automatically on new commits.