feat: add configurable global UI banner visibility setting - #12
Conversation
Add a new setting sonar.ui.banners.visibility that controls who sees global update/upgrade notification banners. - ALL (default): all logged-in users see banners - ADMINS_ONLY: only users with global Admin permission see banners - DISABLED: no users see banners The setting is read from appState.settings and gates the UpdateNotification component. When DISABLED, the system upgrades API call is also skipped entirely.
aae68bc to
9f857a6
Compare
Code Review ✅ Approved 1 resolved / 1 findingsImplements the sonar.ui.banners.visibility setting to control global notification banner access for administrators. The default 'ALL' fallback maintains existing behavior for non-admin users, and no issues were found. ✅ 1 resolved✅ Bug: Default fallback 'ALL' changes existing behavior for non-admin users
OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
|
The associated PR on the sonarqube repository was closed since it does not match with the PM roadmap. |
What problem does this solve?
Administrators have no way to control who sees global update/upgrade notification banners. This adds a configurable setting to give admins that control.
What does this change?
Adds a new setting
sonar.ui.banners.visibilitythat controls who sees global update/upgrade notification banners.ALLADMINS_ONLY(default)DISABLEDFiles changed
libs/sq-server-commons/src/types/settings.ts— addsBannersVisibilitytoGlobalSettingKeysapps/sq-server/src/main/js/app/components/update-notification/UpdateNotification.tsx— reads the setting and gates visibility accordinglyapps/sq-server/src/main/js/app/components/__tests__/UpdateNotification-it.tsx— adds tests covering all three modes