Skip to content

small refactor #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

small refactor #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 19 additions & 22 deletions macros/src/clickhouse/types.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,29 +18,26 @@ pub(crate) enum ClickhouseTableKind {
impl ClickhouseTableKind {
pub(crate) fn get_table_type(file_path: &str) -> Self {
let file_str = std::fs::read_to_string(file_path)
.unwrap_or_else(|_| panic!("Failed to read {}", file_path));
if file_str.contains(&ClickhouseTableKind::Distributed.to_string()) {
ClickhouseTableKind::Distributed
} else if file_str.contains(&ClickhouseTableKind::RemoteSecure.to_string()) {
ClickhouseTableKind::RemoteSecure
} else if file_str.contains(&ClickhouseTableKind::Remote.to_string()) {
ClickhouseTableKind::Remote
} else if file_str.contains(&ClickhouseTableKind::ReplicatedMergeTree.to_string()) {
ClickhouseTableKind::ReplicatedMergeTree
} else if file_str
.contains(&ClickhouseTableKind::ReplicatedAggregatingMergeTree.to_string())
{
ClickhouseTableKind::ReplicatedAggregatingMergeTree
} else if file_str.contains(&ClickhouseTableKind::ReplicatedReplacingMergeTree.to_string())
{
ClickhouseTableKind::ReplicatedReplacingMergeTree
} else if file_str.contains(&ClickhouseTableKind::MaterializedView.to_string()) {
ClickhouseTableKind::MaterializedView
} else if file_str.contains(&ClickhouseTableKind::Null.to_string()) {
ClickhouseTableKind::Null
} else {
panic!("None of the table engines match!")
.expect(format!("Failed to read file {}", file_path).as_str());

let table_types = [
ClickhouseTableKind::Distributed,
ClickhouseTableKind::RemoteSecure,
ClickhouseTableKind::Remote,
ClickhouseTableKind::ReplicatedMergeTree,
ClickhouseTableKind::ReplicatedAggregatingMergeTree,
ClickhouseTableKind::ReplicatedReplacingMergeTree,
ClickhouseTableKind::MaterializedView,
ClickhouseTableKind::Null,
];

for table_type in &table_types {
if file_str.contains(&table_type.to_string()) {
return table_type.clone();
}
}

panic!("None of the table engines match!");
}
}

Expand Down