SQL over CSV with tests and docs #1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool. This is nice 👍 |
tommysitu
reviewed
Aug 25, 2024
tommysitu
reviewed
Aug 25, 2024
tommysitu
reviewed
Aug 25, 2024
tommysitu
reviewed
Aug 25, 2024
tommysitu
reviewed
Aug 25, 2024
tommysitu
reviewed
Aug 25, 2024
core/templating/datasource_query.go
Outdated
| conditions := query.Conditions | ||
| setClauses := query.SetClauses | ||
| for i, row := range (*data)[1:] { | ||
| rowMap := mapRow(headers, row) |
There was a problem hiding this comment.
I started to think that it might be better to store the data as []map[string]string rather than [][]string if we are doing a lot of querying.
There was a problem hiding this comment.
Agreed - might be worth doing
There was a problem hiding this comment.
Not done - should be simple enough to refactor but quite a lot of changes
There was a problem hiding this comment.
let's leave it for another PR.
tommysitu
reviewed
Aug 26, 2024
tommysitu
reviewed
Aug 26, 2024
tommysitu
reviewed
Aug 26, 2024
tommysitu
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for SELECT, UPDATE, DELETE over CSV data sources in csvSQL template function.
Intention is to allow users to simulate a persistent CRUD datastore in a straightforward manner.
This in addition to template function earlier for simpler datasource manipulation.
Have included tests and documentation.
I am not sure how the documentation will render once compiled.