-
Notifications
You must be signed in to change notification settings - Fork 78
Ci build #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Ci build #15
Changes from all commits
9aae982
6b2cd82
85d0f56
84bdd09
2346b21
9f1f543
aa4d064
8601d57
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
name: Build protobuf stubs | ||
|
||
on: | ||
push: | ||
paths: | ||
- src/** | ||
- CMakeLists.txt | ||
- .github/** | ||
workflow_dispatch: | ||
|
||
jobs: | ||
build: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v3 | ||
- uses: actions/setup-node@v3 | ||
with: | ||
node-version: "16" | ||
#- name: Install additional tooling | ||
# run: | | ||
# sudo apt install -y protobuf-compiler-grpc libgrpc6 libgrpc++1 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove these commented out items. |
||
- uses: eWaterCycle/setup-grpc@v5 | ||
- name: Install Protoc | ||
uses: arduino/setup-protoc@v1 | ||
#with: | ||
# version: '3.6' | ||
- name: install pip dependencies | ||
run: pip3 install grpcio-tools | ||
- name: CMake & Build | ||
run: | | ||
cmake . | ||
cmake --build . | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This needs to run the clean target first as sometimes it seems to skip some files during build, probably something that can be fixed with the cmake configuration but until it is need to clean before build. |
||
- name: Commit files | ||
run: | | ||
git config --local user.name "dmarx" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should not override the default action user. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this will run into the same issue described in the sdk CI: pretty sure if I don't configure a user, it'll just complain. How do we make sure a default action user is configured? or should we just choose a consistent username for gh actions? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as there:
|
||
git add ./gooseai/* | ||
git commit -m "Updated protobuf files" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Possibly could use a better commit message as this sounds more like updating the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yup, that was a copypaste from the sdk CI, my b |
||
- name: Push change | ||
uses: ad-m/github-push-action@master | ||
with: | ||
github_token: ${{ secrets.GITHUB_TOKEN }} | ||
branch: ${{ github.ref }} | ||
#force: true |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
module github.com/stability-ai/api-interfaces/gooseai | ||
|
||
go 1.18 | ||
go 1.17 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We want to keep this at There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yeah I have no idea why that changed and it freaked me out a bit when I first saw it. might need to force a version in one of the CI actions |
||
|
||
require ( | ||
google.golang.org/grpc v1.49.0 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If left on all branches then it will regenerate in work branches which I don't think is ideal.