Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused s3fs dependency #116

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

ggilder
Copy link
Contributor

@ggilder ggilder commented Jul 2, 2024

I noticed that it takes quite a while to download the various dependencies of s3fs during pip install, and it appears that s3fs is not actually referenced anywhere in the repo (see search). So no need to include in setup.py.

@ggilder
Copy link
Contributor Author

ggilder commented Jul 2, 2024

For more context - doing pip install stable-audio-tools takes a long time downloading multiple versions of s3fs as well as its dependencies like boto3, botocore and aiobotocore, with messages like:

INFO: pip is looking at multiple versions of s3fs to determine which version is compatible with other requirements. This could take a while.

@ggilder
Copy link
Contributor Author

ggilder commented Aug 5, 2024

@zqevans any opposition to this?

@akx
Copy link
Contributor

akx commented Aug 22, 2024

#139 is related.

@zqevans zqevans merged commit fe5b4a9 into Stability-AI:main Dec 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants