-
Notifications
You must be signed in to change notification settings - Fork 452
BUNNY_DNS: Support DNSSEC and fix Null MX parsing #3547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Log from running integration tests for
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements the
AUTODNSSEC
capability for Bunny DNS, based on the recently released API endpoints. I've tested proper state handling on my side and double-checked manually against the Bunny API too:Additionally, I've noticed that integration tests were failing for the renull NullMX test cases, which happened due to
fromRecordConfig
stripping.
from any FQDN-like record unconditionally, as is usually desired and in alignment withtoRecordConfig
.However in case of
type == MX && pref == 0 && value == "."
the single dot must be preserved as-is, given its special meaning as a NullMX record, which has been fixed in a separate commit. The full test suite is now properly passing again.Fixes #3513