implement admin push notification controller #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔥🔥🔥 Backend CI Failed. github action link 🔥🔥🔥 |
Zeniuus
reviewed
Nov 12, 2024
| ) | ||
| } | ||
|
|
||
| transactionManager.doAfterCommit { |
There was a problem hiding this comment.
굳이 doAfterCommit에 넣을 필요가 있나요? 걍 트랜잭션 밖에서 해도 될 것 같아서용
There was a problem hiding this comment.
ㅇㅎ 저는 그냥 두개가 같다고 생각했는데 수환님은 doAfterCommit이 PersistentContext에 접근 가능한 것을 염두하고 "트랜잭션 밖" 이라고 말씀하신거죠?
Comment on lines
+575
to
+595
| schema: | ||
| type: object | ||
| properties: | ||
| userIds: | ||
| type: array | ||
| items: | ||
| type: string | ||
| notification: | ||
| type: object | ||
| properties: | ||
| title: | ||
| type: string | ||
| body: | ||
| type: string | ||
| deepLink: | ||
| type: string | ||
| required: | ||
| - body | ||
| required: | ||
| - userIds | ||
| - notification |
There was a problem hiding this comment.
이거 약간 컨벤션이 없긴 한데, request dto를 따로 만드는 게 좋은 것 같습니다. 이렇게 하면 openapi generator가 지맘대로 dto class를 생성하는데, 이 dto class 이름이 openapi generator 버전 따라서 조금씩 달라지더라구요.
Zeniuus
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
충분한 양의 자동화 테스트를 작성했는가?
아직 테스트는 작성안하였습니다.
너무 오랜만에 비즈니스 로직 짜는거라 감을 잃었어요... 회초리 부탁드립ㄴ디ㅏ.
admin 을 통해 호출할거지만 한동안 admin 페이지가 만들어지기 전까지는 서버내에서 호출할거라 인증을 붙여야 하는지 아직 모르겠네요
애초에 이 controller가 user domain에 속하는지 좀 아리송합니다.