Prevent segfault when dladdr return values are NULL#324
Open
dinodeep wants to merge 5 commits intoStanfordLegion:mainfrom
Open
Prevent segfault when dladdr return values are NULL#324dinodeep wants to merge 5 commits intoStanfordLegion:mainfrom
dinodeep wants to merge 5 commits intoStanfordLegion:mainfrom
Conversation
muraj
approved these changes
Oct 1, 2025
Signed-off-by: Deep Patel <68748791+dinodeep@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
dladdr(ptr, &inf)returns, it's possible that it will return a non-zero return value (indicating success) when it finds a shared object containingptr. However, if there isn't a symbol associated with the ptr from the shared object, thendladdrwill setdli_snameanddli_saddrfields to null which Realm currently reads from without checking for NULL.This PR ensures that NULL is checked for and provides an appropriate error message if that is the case.
Quote from
dladdrlinux man page