Skip to content

Consolidate loader logic to cross platform class#325

Open
muraj wants to merge 4 commits intomainfrom
cperry/loader
Open

Consolidate loader logic to cross platform class#325
muraj wants to merge 4 commits intomainfrom
cperry/loader

Conversation

@muraj
Copy link
Copy Markdown
Contributor

@muraj muraj commented Oct 1, 2025

This change adds a Loader class that can be used to easily create a dynamic loader for a library and works across platforms.

@muraj muraj requested review from apryakhin and eddy16112 October 1, 2025 16:34
@muraj muraj self-assigned this Oct 1, 2025
@muraj muraj added the chore label Oct 1, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 1, 2025

Codecov Report

❌ Patch coverage is 72.22222% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 27.27%. Comparing base (a747afb) to head (299ba4b).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/realm/module.cc 0.00% 15 Missing ⚠️
src/realm/network.cc 0.00% 8 Missing ⚠️
src/realm/loader.cc 94.11% 1 Missing ⚠️
src/realm/loader.h 95.23% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #325      +/-   ##
==========================================
+ Coverage   27.15%   27.27%   +0.12%     
==========================================
  Files         190      193       +3     
  Lines       39174    39232      +58     
  Branches    14359    14376      +17     
==========================================
+ Hits        10636    10701      +65     
+ Misses      28144    28137       -7     
  Partials      394      394              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@muraj muraj force-pushed the cperry/loader branch 5 times, most recently from 1ea99d0 to beeb413 Compare October 1, 2025 19:06
@muraj muraj marked this pull request as ready for review October 1, 2025 19:27
Comment thread src/realm/gasnetex/gasnetex_internal.cc
@apryakhin
Copy link
Copy Markdown
Contributor

I am ready to approve. Overall that's looking good. I will do a few more passes though.

@muraj muraj force-pushed the cperry/loader branch 4 times, most recently from ee08f7b to 25b2842 Compare October 6, 2025 19:42
@muraj muraj requested a review from apryakhin October 7, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants