Remove abort path from a failed rdma registration in gasnet#346
Open
Remove abort path from a failed rdma registration in gasnet#346
Conversation
Contributor
Author
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #346 +/- ##
=========================================
Coverage 27.15% 27.15%
=========================================
Files 190 190
Lines 39174 39174
Branches 14170 14359 +189
=========================================
Hits 10637 10637
- Misses 27128 28144 +1016
+ Partials 1409 393 -1016 ☔ View full report in Codecov by Sentry. |
muraj
force-pushed
the
cperry/gasnet-rdma-abort
branch
2 times, most recently
from
53000a0 to
0a54cbe
Compare
muraj
force-pushed
the
cperry/gasnet-rdma-abort
branch
from
0a54cbe to
8d480c7
Compare
eddy16112
reviewed
Nov 4, 2025
|
|
||
| if(gex_wrapper_handle.gex_ep_bind_segment(ep, segment, 0 /*flags*/) != 0) { | ||
| // TODO: destroy the segment and ep we created? | ||
| return false; |
Contributor
There was a problem hiding this comment.
Let's add a warning message here.
Contributor
Author
There was a problem hiding this comment.
Why, so application can just disable it? Enabling gasnet warnings when debugging this is enough for now I think.
Contributor
There was a problem hiding this comment.
Enabling gasnet warnings when debugging this is enough for now I think.
We do not have warnings if bind segment is failed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.