Add support for building fatbin from clang ptx#368
Open
rbberger wants to merge 1 commit intoStanfordLegion:mainfrom
Open
Add support for building fatbin from clang ptx#368rbberger wants to merge 1 commit intoStanfordLegion:mainfrom
rbberger wants to merge 1 commit intoStanfordLegion:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #368 +/- ##
==========================================
- Coverage 27.74% 27.74% -0.01%
==========================================
Files 192 192
Lines 39502 39502
Branches 14382 14382
==========================================
- Hits 10960 10959 -1
Misses 28151 28151
- Partials 391 392 +1 ☔ View full report in Codecov by Sentry. |
muraj
approved these changes
Nov 26, 2025
e7f80d0 to
5166709
Compare
Signed-off-by: Richard Berger <rberger@lanl.gov>
5166709 to
cf17e6c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables building the embedded fatbinary using ptx generated by Clang. It is currently restricted to a single
.cufile in$REALM_CUDA_SOURCESand a single$CMAKE_CUDA_ARCHITECTURES. The single.curestriction is already the case also for the NVCC path anyway.For more SMs per translation unit we would have to either ask CMake to fix their CUDA_PTX_COMPILATION support, or manually do it via loops and custom targets/commands. For the FleCSI use case both restrictions are currently sufficient.