Skip to content

src/realm: allow for XferDes objects to be reset#416

Open
rohany wants to merge 1 commit intoStanfordLegion:mainfrom
rohany:xd-reset
Open

src/realm: allow for XferDes objects to be reset#416
rohany wants to merge 1 commit intoStanfordLegion:mainfrom
rohany:xd-reset

Conversation

@rohany
Copy link
Copy Markdown
Contributor

@rohany rohany commented Mar 25, 2026

This commit ports the XferDes reset functionality from #391.

This commit ports the XferDes reset functionality from StanfordLegion#391.
@rohany rohany requested a review from apryakhin March 25, 2026 20:36
@rohany
Copy link
Copy Markdown
Contributor Author

rohany commented Mar 25, 2026

@artempriakhin do you have some suggestions for how to test this in isolation? I was playing around with a few things this morning and didn't find any of them particularly satisfying / self contained:

  • None of the types changed here are really POD types with byte equality. I can add tests that check all the "resetted" fields are indeed "reset", but it doesn't do anything for us in the future to avoid someone adding a new field and not resetting it.
  • I could try more end-to-end tests that check an XD is actually replayable, but this isn't a unit test and more and requires a good amount infrastructure I have in the subgraph PR to actually extract an XD to run it back-to-back several times.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2026

Codecov Report

❌ Patch coverage is 0% with 94 lines in your changes missing coverage. Please review.
✅ Project coverage is 29.00%. Comparing base (7cd30c1) to head (835aae2).
⚠️ Report is 14 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/realm/transfer/channel.cc 0.00% 71 Missing ⚠️
src/realm/transfer/address_list.cc 0.00% 12 Missing ⚠️
src/realm/transfer/transfer.cc 0.00% 8 Missing ⚠️
src/realm/transfer/transfer.inl 0.00% 2 Missing ⚠️
src/realm/transfer/lowlevel_dma.h 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #416      +/-   ##
==========================================
+ Coverage   28.22%   29.00%   +0.78%     
==========================================
  Files         193      194       +1     
  Lines       39849    40318     +469     
  Branches    14433    14614     +181     
==========================================
+ Hits        11246    11695     +449     
  Misses      28206    28206              
- Partials      397      417      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant