Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Support limit dir size for spill #26787

Merged
merged 3 commits into from
Aug 24, 2023
Merged

[Enhancement] Support limit dir size for spill #26787

merged 3 commits into from
Aug 24, 2023

Conversation

caneGuy
Copy link
Contributor

@caneGuy caneGuy commented Jul 10, 2023 •
edited
Loading

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr will affect users' behaviors
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.1
    • 3.0
    • 2.5
    • 2.4

@github-actions github-actions bot added the 3.1 label Jul 10, 2023
@caneGuy caneGuy force-pushed the zhoukang/spill-disk-space branch 3 times, most recently from 330cea3 to 36cdc29 Compare July 14, 2023 02:35
@caneGuy
resolve comments
48fe05b 
Signed-off-by: caneGuy <[email protected]>
@wanpengfei-git
Copy link
Collaborator

[FE PR Coverage Check]

😍 pass : 0 / 0 (0%)

@caneGuy
resolve comments
760d31a 
Signed-off-by: caneGuy <[email protected]>
@wanpengfei-git
Copy link
Collaborator

[FE Incremental Coverage Report]

😍 pass : 0 / 0 (0%)

@wanpengfei-git
Copy link
Collaborator

[BE Incremental Coverage Report]

😍 pass : 22 / 27 (81.48%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 src/exec/spill/log_block_manager.cpp 2 4 50.00% [172, 173]
🔵 src/exec/spill/dir_manager.cpp 10 13 76.92% [57, 58, 60]
🔵 src/exec/spill/dir_manager.h 10 10 100.00% []

@caneGuy caneGuy merged commit d752509 into StarRocks:main Aug 24, 2023
36 of 39 checks passed
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-3.1

@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-3.0

@mergify
Copy link
Contributor

mergify bot commented Aug 24, 2023 •
edited
Loading

backport branch-3.1

✅ Backports have been created

@mergify
Copy link
Contributor

mergify bot commented Aug 24, 2023 •
edited
Loading

backport branch-3.0

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 24, 2023
@caneGuy @mergify
[Enhancement] Support limit dir size for spill (#26787)
3542c50 
Signed-off-by: caneGuy <[email protected]>
(cherry picked from commit d752509)
mergify bot pushed a commit that referenced this pull request Aug 24, 2023
@caneGuy @mergify
[Enhancement] Support limit dir size for spill (#26787)
a50ca7a 
Signed-off-by: caneGuy <[email protected]>
(cherry picked from commit d752509)
This was referenced Aug 24, 2023
Closed
Closed
Jay-ju pushed a commit to Jay-ju/starrocks that referenced this pull request Sep 7, 2023
@caneGuy @Jay-ju
[Enhancement] Support limit dir size for spill (StarRocks#26787)
278e1d4 
Signed-off-by: caneGuy <[email protected]>
silverbullet233 pushed a commit that referenced this pull request Nov 17, 2023
@caneGuy @silverbullet233
[Enhancement] Support limit dir size for spill (#26787)
4f4a12f 
Signed-off-by: caneGuy <[email protected]>
(cherry picked from commit d752509)
silverbullet233 pushed a commit that referenced this pull request Nov 17, 2023
@caneGuy @silverbullet233
[Enhancement] Support limit dir size for spill (#26787)
d0c0768 
Signed-off-by: caneGuy <[email protected]>
(cherry picked from commit d752509)
@caneGuy caneGuy deleted the zhoukang/spill-disk-space branch July 10, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silverbullet233 silverbullet233 silverbullet233 approved these changes

@stdpain stdpain stdpain approved these changes

@yingtingdong yingtingdong Awaiting requested review from yingtingdong

@wangsimo0 wangsimo0 Awaiting requested review from wangsimo0

Assignees

@caneGuy caneGuy

Labels
behavior_changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@caneGuy @wanpengfei-git @silverbullet233 @stdpain @jaogoy