Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] No need to build_slice for get data from BinaryColumn #30702

Merged
merged 2 commits into from
Sep 11, 2023
Merged

[Enhancement] No need to build_slice for get data from BinaryColumn #30702

merged 2 commits into from
Sep 11, 2023

Conversation

trueeyu
Copy link
Contributor

@trueeyu trueeyu commented Sep 11, 2023 •
edited
Loading

Fixes #issue

There are two main purposes:

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.1
    • 3.0
    • 2.5
    • 2.4

@trueeyu
fix
e7a4eee 
Signed-off-by: trueeyu <[email protected]>
@wanpengfei-git
Copy link
Collaborator

[FE Incremental Coverage Report]

😍 pass : 0 / 0 (0%)

@wanpengfei-git
Copy link
Collaborator

[BE Incremental Coverage Report]

😍 pass : 21 / 21 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 src/util/arrow/starrocks_column_to_arrow.cpp 21 21 100.00% []

@trueeyu trueeyu merged commit 2d86dd2 into StarRocks:main Sep 11, 2023
24 checks passed
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-3.1

@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-3.0

@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-2.5

@github-actions github-actions bot removed the 2.5 label Sep 11, 2023
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-2.4

@github-actions github-actions bot removed the 2.4 label Sep 11, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 11, 2023 •
edited
Loading

backport branch-3.1

✅ Backports have been created

@mergify
Copy link
Contributor

mergify bot commented Sep 11, 2023 •
edited
Loading

backport branch-3.0

✅ Backports have been created

@mergify
Copy link
Contributor

mergify bot commented Sep 11, 2023 •
edited
Loading

backport branch-2.5

✅ Backports have been created

@mergify
Copy link
Contributor

mergify bot commented Sep 11, 2023 •
edited
Loading

backport branch-2.4

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 11, 2023
@trueeyu @mergify
[Enhancement] No need to build_slice for get data from BinaryColumn (#…
765b4d9 
…30702)

Signed-off-by: trueeyu <[email protected]>
(cherry picked from commit 2d86dd2)
This was referenced Sep 11, 2023
Merged
Merged
mergify bot pushed a commit that referenced this pull request Sep 11, 2023
@trueeyu @mergify
[Enhancement] No need to build_slice for get data from BinaryColumn (#…
0ba85cb 
…30702)

Signed-off-by: trueeyu <[email protected]>
(cherry picked from commit 2d86dd2)

# Conflicts:
#	be/src/util/arrow/starrocks_column_to_arrow.cpp
mergify bot pushed a commit that referenced this pull request Sep 11, 2023
@trueeyu @mergify
[Enhancement] No need to build_slice for get data from BinaryColumn (#…
1976eb0 
…30702)

Signed-off-by: trueeyu <[email protected]>
(cherry picked from commit 2d86dd2)
@mergify mergify bot mentioned this pull request Sep 11, 2023
Closed
mergify bot pushed a commit that referenced this pull request Sep 11, 2023
@trueeyu @mergify
[Enhancement] No need to build_slice for get data from BinaryColumn (#…
3ee3fe3 
…30702)

Signed-off-by: trueeyu <[email protected]>
(cherry picked from commit 2d86dd2)

# Conflicts:
#	be/src/util/arrow/starrocks_column_to_arrow.cpp
@mergify mergify bot mentioned this pull request Sep 11, 2023
Closed
imay pushed a commit that referenced this pull request Sep 11, 2023
@mergify @trueeyu
[Enhancement] No need to build_slice for get data from BinaryColumn (…
bb10641 
…backport #30702) (#30745)

Co-authored-by: trueeyu <[email protected]>
imay pushed a commit that referenced this pull request Sep 11, 2023
@mergify @trueeyu
[Enhancement] No need to build_slice for get data from BinaryColumn (…
8e62f81 
…backport #30702) (#30746)

Co-authored-by: trueeyu <[email protected]>
trueeyu added a commit to trueeyu/starrocks that referenced this pull request Sep 12, 2023
@trueeyu
[Enhancement] No need to build_slice for get data from BinaryColumn (S…
c063f94 
…tarRocks#30702)

Signed-off-by: trueeyu <[email protected]>
trueeyu added a commit to trueeyu/starrocks that referenced this pull request Sep 12, 2023
@trueeyu
[Enhancement] No need to build_slice for get data from BinaryColumn (S…
b0dce56 
…tarRocks#30702)

Signed-off-by: trueeyu <[email protected]>
trueeyu added a commit to trueeyu/starrocks that referenced this pull request Sep 12, 2023
@trueeyu
[Enhancement] No need to build_slice for get data from BinaryColumn (S…
ee8db42 
…tarRocks#30702)

Signed-off-by: trueeyu <[email protected]>
trueeyu added a commit to trueeyu/starrocks that referenced this pull request Sep 12, 2023
@trueeyu
[Enhancement] No need to build_slice for get data from BinaryColumn (S…
5055b55 
…tarRocks#30702)

Signed-off-by: trueeyu <[email protected]>
chaoyli pushed a commit that referenced this pull request Sep 12, 2023
@trueeyu
[Enhancement] No need to build_slice for get data from BinaryColumn (#…
77ca15d 
…30702) (#30811)

Signed-off-by: trueeyu <[email protected]>
chaoyli pushed a commit that referenced this pull request Sep 12, 2023
@trueeyu
[Enhancement] No need to build_slice for get data from BinaryColumn (#…
5257a52 
…30702) (#30810)

Signed-off-by: trueeyu <[email protected]>
chaoyli pushed a commit that referenced this pull request Sep 12, 2023
@trueeyu
[Enhancement] No need to build_slice for get data from BinaryColumn (#…
7bf732c 
…30702) (#30809)

Signed-off-by: trueeyu <[email protected]>
chaoyli pushed a commit that referenced this pull request Sep 12, 2023
@trueeyu
[Enhancement] No need to build_slice for get data from BinaryColumn (#…
0aca2b8 
…30702) (#30802)

Signed-off-by: trueeyu <[email protected]>
@trueeyu
Copy link
Contributor Author

trueeyu commented Sep 12, 2023

https://github.com/Mergifyio backport branch-2.4

@mergify
Copy link
Contributor

mergify bot commented Sep 12, 2023

backport branch-2.4

✅ Backports have been created

@trueeyu
Copy link
Contributor Author

trueeyu commented Sep 12, 2023

https://github.com/Mergifyio backport branch-3.2

@mergify
Copy link
Contributor

mergify bot commented Sep 12, 2023 •
edited
Loading

backport branch-3.2

✅ Backports have been created

  • Backport to branch branch-3.2 not needed, change already in branch branch-3.2

trueeyu added a commit to trueeyu/starrocks that referenced this pull request Sep 12, 2023
@mergify @trueeyu
[Enhancement] No need to build_slice for get data from BinaryColumn (…
1d2d64f 
…backport StarRocks#30702) (StarRocks#30745)

Co-authored-by: trueeyu <[email protected]>
@trueeyu trueeyu mentioned this pull request Sep 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaoyli chaoyli chaoyli approved these changes

@decster decster decster approved these changes

Assignees

@trueeyu trueeyu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trueeyu @wanpengfei-git @decster @chaoyli