-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Support insert timeout #50644
Merged
Merged
+344
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaogoy
reviewed
Sep 5, 2024
wyb
force-pushed
the
ins_timeout
branch
2 times, most recently
from
September 17, 2024 02:48
10874fd
to
a76bca3
Compare
wyb
force-pushed
the
ins_timeout
branch
2 times, most recently
from
September 20, 2024 09:03
8d61a2c
to
64d2634
Compare
Quality Gate passedIssues Measures |
wyb
force-pushed
the
ins_timeout
branch
5 times, most recently
from
November 6, 2024 12:05
1ad4f77
to
3eaaffb
Compare
meegoo
reviewed
Nov 7, 2024
jaogoy
previously approved these changes
Nov 7, 2024
wyb
force-pushed
the
ins_timeout
branch
3 times, most recently
from
November 8, 2024 06:59
b4a8a58
to
0daa644
Compare
wyb
force-pushed
the
ins_timeout
branch
2 times, most recently
from
November 8, 2024 07:14
1b84414
to
14a14f2
Compare
LiShuMing
previously approved these changes
Nov 8, 2024
wyb
force-pushed
the
ins_timeout
branch
2 times, most recently
from
November 10, 2024 04:22
d5be463
to
380c400
Compare
meegoo
previously approved these changes
Nov 10, 2024
gengjun-git
previously approved these changes
Nov 11, 2024
Signed-off-by: wyb <[email protected]>
Signed-off-by: wyb <[email protected]>
Signed-off-by: wyb <[email protected]>
Signed-off-by: wyb <[email protected]>
and make mv default timeout as insert_timeout Signed-off-by: wyb <[email protected]>
Signed-off-by: wyb <[email protected]>
Signed-off-by: wyb <[email protected]>
Signed-off-by: wyb <[email protected]>
Quality Gate passedIssues Measures |
meegoo
approved these changes
Nov 12, 2024
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 79 / 93 (84.95%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
gengjun-git
approved these changes
Nov 12, 2024
Seaven
approved these changes
Nov 13, 2024
jaogoy
reviewed
Nov 13, 2024
jaogoy
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
insert
andquery
use the samequery_timeout
session variable to control timeout.but they need different default values, default
query_timeout 300s
is very small for insert.What I'm doing:
add a new
insert_timeout
session variable forinsert/update/delete
and the default value is14400s
.you can also set
timeout
ininsert properties
for the current insert sql, for exampleif
timeout
property is not set,insert_timeout
session variable will be used.Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: