-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] (Part3) Support creating materialized views with common aggregate state functions #51510
Merged
LiShuMing
merged 1 commit into
StarRocks:main
from
LiShuMing:fix/main/support_agg_state_with_sync_mv
Oct 12, 2024
Merged
[Feature] (Part3) Support creating materialized views with common aggregate state functions #51510
LiShuMing
merged 1 commit into
StarRocks:main
from
LiShuMing:fix/main/support_agg_state_with_sync_mv
Oct 12, 2024
+1,584
−199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fe/fe-core/src/main/java/com/starrocks/sql/ast/CreateMaterializedViewStmt.java
Show resolved
Hide resolved
LiShuMing
changed the title
[Feature] [WIP] Support creating synchroninzed materialied views with common agg state functions
[Feature] Support creating synchroninzed materialied views with common agg state functions
Oct 8, 2024
LiShuMing
force-pushed
the
fix/main/support_agg_state_with_sync_mv
branch
2 times, most recently
from
October 9, 2024 12:17
9318ddd
to
4cb00d5
Compare
LiShuMing
changed the title
[Feature] Support creating synchroninzed materialied views with common agg state functions
[Feature] (Part3) Support creating synchroninzed materialied views with common agg state functions
Oct 10, 2024
LiShuMing
changed the title
[Feature] (Part3) Support creating synchroninzed materialied views with common agg state functions
[Feature] (Part3) Support creating materialized views with common aggregate state functions
Oct 10, 2024
3 tasks
LiShuMing
force-pushed
the
fix/main/support_agg_state_with_sync_mv
branch
2 times, most recently
from
October 10, 2024 07:51
20c9788
to
98c5299
Compare
…e functions Signed-off-by: shuming.li <[email protected]>
LiShuMing
force-pushed
the
fix/main/support_agg_state_with_sync_mv
branch
from
October 10, 2024 12:06
98c5299
to
18723c8
Compare
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 202 / 237 (85.23%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Seaven
approved these changes
Oct 12, 2024
gengjun-git
approved these changes
Oct 12, 2024
LiShuMing
added a commit
to LiShuMing/starrocks
that referenced
this pull request
Oct 29, 2024
…regate state functions (StarRocks#51510) Signed-off-by: shuming.li <[email protected]>
chaoyli
pushed a commit
that referenced
this pull request
Oct 29, 2024
…regate state functions (backport #51510) (#52412) Signed-off-by: shuming.li <[email protected]>
saahilbarai
pushed a commit
to pinterest/starrocks
that referenced
this pull request
Oct 30, 2024
…regate state functions (StarRocks#51510) Signed-off-by: shuming.li <[email protected]>
24 tasks
ZiheLiu
pushed a commit
to ZiheLiu/starrocks
that referenced
this pull request
Oct 31, 2024
…regate state functions (StarRocks#51510) Signed-off-by: shuming.li <[email protected]>
renzhimin7
pushed a commit
to renzhimin7/starrocks
that referenced
this pull request
Nov 7, 2024
…regate state functions (StarRocks#51510) Signed-off-by: shuming.li <[email protected]> Signed-off-by: zhiminr.ren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
Since common aggregate state has been supported in aggregate table, we can extend our materialized views' ability to support common aggregate functions.
And also we can use this mv to rewrite query as below:
Besides aggregate table, we can also support common aggregate state functions in duplicated table/asynchronized materialized views, eg:
What I'm doing:
Fixes #49000
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: