[BugFix] Avoid token print in FE log. #52511

xyllq999 · 2024-10-31T15:16:24Z

Signed-off-by: [email protected]

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

Does this PR entail a change in behavior?

Yes, this PR will result in a change in behavior.
No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

Interface/UI changes: syntax, type conversion, expression evaluation, display information
Parameter changes: default values, similar parameters but with different default values
Policy changes: use new policy to replace old one, functionality automatically enabled
Feature removed
Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

I have added test cases for my bug fix or my new feature
This pr needs user documentation (for new or modified features or behaviors)
- I have added documentation for my new feature or new function
This is a backport pr

Bugfix cherry-pick branch check:

fe/fe-core/src/main/java/com/starrocks/common/util/Util.java

Signed-off-by: [email protected] Signed-off-by: xyllq999 <[email protected]>

sonarcloud · 2024-11-04T11:31:20Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

fe/fe-core/src/main/java/com/starrocks/common/util/Util.java

xyllq999 · 2024-11-04T12:10:23Z

@gengjun-git Could you pls review this PR and rerun the pipeline check?

github-actions · 2024-11-05T05:07:10Z

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

github-actions · 2024-11-05T05:07:48Z

[FE Incremental Coverage Report]

❌ fail : 3 / 9 (33.33%)

file detail

	path	covered_line	new_line	coverage	not_covered_line_detail
🔵	com/starrocks/common/util/Util.java	0	4	00.00%	[325, 328, 344, 351]
🔵	com/starrocks/http/rest/RestBaseAction.java	3	5	60.00%	[106, 109]

github-actions · 2024-11-05T05:07:59Z

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

xyllq999 · 2024-11-05T07:22:22Z

[FE Incremental Coverage Report]

❌ fail : 3 / 9 (33.33%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/common/util/Util.java 0 4 00.00% [325, 328, 344, 351]
🔵 com/starrocks/http/rest/RestBaseAction.java 3 5 60.00% [106, 109]

I don't think it's necessary to supplement the UT. It is just about log print. @gengjun-git

github-actions · 2024-11-06T04:50:07Z

@Mergifyio backport branch-3.3

github-actions · 2024-11-06T04:50:08Z

@Mergifyio backport branch-3.2

mergify · 2024-11-06T04:50:34Z

backport branch-3.3

✅ Backports have been created

#52663 [BugFix] Avoid token print in FE log. (backport #52511) has been created for branch branch-3.3

mergify · 2024-11-06T04:50:35Z

backport branch-3.2

✅ Backports have been created

#52664 [BugFix] Avoid token print in FE log. (backport #52511) has been created for branch branch-3.2 but encountered conflicts

Signed-off-by: [email protected] Signed-off-by: xyllq999 <[email protected]> (cherry picked from commit a0b2d35)

Signed-off-by: [email protected] Signed-off-by: xyllq999 <[email protected]> (cherry picked from commit a0b2d35) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/common/util/Util.java

Co-authored-by: xyllq999 <[email protected]>

Signed-off-by: [email protected] Signed-off-by: xyllq999 <[email protected]> Signed-off-by: zhiminr.ren <[email protected]>

Signed-off-by: Kevin Xiaohua Cai <[email protected]> Co-authored-by: xyllq999 <[email protected]> Co-authored-by: Kevin Xiaohua Cai <[email protected]>

xyllq999 requested review from a team as code owners October 31, 2024 15:16

github-actions bot added the title needs [type] label Oct 31, 2024

mergify bot assigned xyllq999 Oct 31, 2024

xyllq999 changed the title ~~避免FE日志打印URL打印明文token，修改GET请求为POST。~~ [BugFix] Avoid token print in FE log by change GET to POST url. Oct 31, 2024

github-actions bot removed the title needs [type] label Oct 31, 2024

xyllq999 force-pushed the main-post branch from b90ac07 to 78bb9a4 Compare October 31, 2024 15:52

xyllq999 changed the title ~~[BugFix] Avoid token print in FE log by change GET to POST url.~~ [BugFix] Avoid token print in FE log. Nov 1, 2024

xyllq999 force-pushed the main-post branch from f7aaee3 to 377fff6 Compare November 1, 2024 14:29

github-actions bot added 3.3 3.2 labels Nov 2, 2024

kevincai reviewed Nov 4, 2024

View reviewed changes

fe/fe-core/src/main/java/com/starrocks/common/util/Util.java Outdated Show resolved Hide resolved

xyllq999 force-pushed the main-post branch from 377fff6 to 5276f74 Compare November 4, 2024 11:10

github-actions bot deleted a comment from xyllq999 Nov 4, 2024

xyllq999 force-pushed the main-post branch from 5276f74 to 129637c Compare November 4, 2024 11:15

避免FE日志打印URL打印明文token。

211059b

Signed-off-by: [email protected] Signed-off-by: xyllq999 <[email protected]>

xyllq999 force-pushed the main-post branch from 129637c to 211059b Compare November 4, 2024 11:18

避免FE日志打印URL打印明文token。

091f3bc

Signed-off-by: [email protected] Signed-off-by: xyllq999 <[email protected]>

xyllq999 requested a review from kevincai November 4, 2024 11:33

kevincai reviewed Nov 4, 2024

View reviewed changes

fe/fe-core/src/main/java/com/starrocks/common/util/Util.java Show resolved Hide resolved

kevincai approved these changes Nov 4, 2024

View reviewed changes

gengjun-git approved these changes Nov 5, 2024

View reviewed changes

alvin-celerdata merged commit a0b2d35 into StarRocks:main Nov 6, 2024
61 of 62 checks passed

github-actions bot removed 3.3 3.2 labels Nov 6, 2024

mergify bot pushed a commit that referenced this pull request Nov 6, 2024

[BugFix] Avoid token print in FE log. (#52511)

2edb3f8

Signed-off-by: [email protected] Signed-off-by: xyllq999 <[email protected]> (cherry picked from commit a0b2d35)

mergify bot mentioned this pull request Nov 6, 2024

[BugFix] Avoid token print in FE log. (backport #52511) #52663

Merged

42 tasks

mergify bot mentioned this pull request Nov 6, 2024

[BugFix] Avoid token print in FE log. (backport #52511) #52664

Merged

42 tasks

wanpengfei-git pushed a commit that referenced this pull request Nov 6, 2024

[BugFix] Avoid token print in FE log. (backport #52511) (#52663)

264ef9d

Co-authored-by: xyllq999 <[email protected]>

github-actions bot added the 3.3-merged label Nov 6, 2024

renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024

[BugFix] Avoid token print in FE log. (StarRocks#52511)

4b60673

Signed-off-by: [email protected] Signed-off-by: xyllq999 <[email protected]> Signed-off-by: zhiminr.ren <[email protected]>

github-actions bot added the 3.2-merged label Nov 9, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BugFix] Avoid token print in FE log. #52511

[BugFix] Avoid token print in FE log. #52511

xyllq999 commented Oct 31, 2024 •

edited

Loading

sonarcloud bot commented Nov 4, 2024

xyllq999 commented Nov 4, 2024 •

edited

Loading

github-actions bot commented Nov 5, 2024

github-actions bot commented Nov 5, 2024

github-actions bot commented Nov 5, 2024

xyllq999 commented Nov 5, 2024 •

edited

Loading

[FE Incremental Coverage Report]

file detail

github-actions bot commented Nov 6, 2024

github-actions bot commented Nov 6, 2024

mergify bot commented Nov 6, 2024 •

edited

Loading

mergify bot commented Nov 6, 2024 •

edited

Loading

[BugFix] Avoid token print in FE log. #52511

[BugFix] Avoid token print in FE log. #52511

Conversation

xyllq999 commented Oct 31, 2024 • edited Loading

Why I'm doing:

What I'm doing:

What type of PR is this:

Checklist:

Bugfix cherry-pick branch check:

sonarcloud bot commented Nov 4, 2024

Quality Gate passed

xyllq999 commented Nov 4, 2024 • edited Loading

github-actions bot commented Nov 5, 2024

[Java-Extensions Incremental Coverage Report]

github-actions bot commented Nov 5, 2024

[FE Incremental Coverage Report]

file detail

github-actions bot commented Nov 5, 2024

[BE Incremental Coverage Report]

xyllq999 commented Nov 5, 2024 • edited Loading

[FE Incremental Coverage Report]

file detail

github-actions bot commented Nov 6, 2024

github-actions bot commented Nov 6, 2024

mergify bot commented Nov 6, 2024 • edited Loading

✅ Backports have been created

mergify bot commented Nov 6, 2024 • edited Loading

✅ Backports have been created

xyllq999 commented Oct 31, 2024 •

edited

Loading

xyllq999 commented Nov 4, 2024 •

edited

Loading

xyllq999 commented Nov 5, 2024 •

edited

Loading

mergify bot commented Nov 6, 2024 •

edited

Loading

mergify bot commented Nov 6, 2024 •

edited

Loading