Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] add lock to avoid publish and update schema run concurrency for pk table (backport #52687) #52783

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 11, 2024

Why I'm doing:

We need to rewrite rowset meta when we update tablet schema. For non-primary key table, we use _meta_lock to prevent publish and update schema run concurrency. However, primary key table does not hold _meta_lock during publish, so update schema and publish could run concurrency. If run concurrency, the pengding_rowset_meta maybe write again after delete and can not be gc.

What I'm doing:

Add lock to prevent run concurrency.

In my test, rewrite 10000 rowset meta(200 columns table) in HDD cost about 1 second. So I believe that holding the lock in rewrite_rs_meta is acceptable.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #52687 done by [Mergify](https://mergify.com). ## Why I'm doing: We need to rewrite rowset meta when we update tablet schema. For non-primary key table, we use `_meta_lock` to prevent publish and update schema run concurrency. However, primary key table does not hold `_meta_lock` during publish, so update schema and publish could run concurrency. If run concurrency, the `pengding_rowset_meta` maybe write again after delete and can not be gc.

What I'm doing:

Add lock to prevent run concurrency.

In my test, rewrite 10000 rowset meta(200 columns table) in HDD cost about 1 second. So I believe that holding the lock in rewrite_rs_meta is acceptable.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

…for pk table (#52687)

Signed-off-by: sevev <[email protected]>
(cherry picked from commit ab928ce)
@wanpengfei-git wanpengfei-git merged commit 22d46ad into branch-3.3 Nov 11, 2024
35 of 36 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.3/pr-52687 branch November 11, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants