Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Support the conversion from json to struct. #52790

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Jcnessss
Copy link
Contributor

@Jcnessss Jcnessss commented Nov 11, 2024

Why I'm doing:

In Trino, a json could be translate into row and array(row). Following sql could be executed:
TRY(CAST(json_parse("json") AS array(ROW(col1 timestamp(3), col2 array(varchar), col3 double, col4 varchar, col5 varchar))))

What I'm doing:

Supporting casting json to struct or array. After this patch, the sql above could be executed under trino dialect.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@Jcnessss Jcnessss force-pushed the cast_json_to_struct branch 9 times, most recently from 9575ce5 to b3f309a Compare November 13, 2024 06:14
Copy link

sonarcloud bot commented Nov 13, 2024

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 6 / 6 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/catalog/Type.java 6 6 100.00% []

Copy link

[BE Incremental Coverage Report]

pass : 87 / 99 (87.88%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/exprs/cast_expr.h 11 14 78.57% [104, 110, 115]
🔵 be/src/exprs/cast_expr.cpp 14 16 87.50% [1607, 1608]
🔵 be/src/exprs/cast_expr_struct.cpp 62 69 89.86% [43, 59, 60, 61, 88, 89, 115]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant