[BugFix] Fix LIKE escaping mismatch with MySQL in constant folding (backport #74814)#75000
Open
Joob1n wants to merge 2 commits into
Open
[BugFix] Fix LIKE escaping mismatch with MySQL in constant folding (backport #74814)#75000Joob1n wants to merge 2 commits into
Joob1n wants to merge 2 commits into
Conversation
…tarRocks#74814) Signed-off-by: Joob1n <1208247864@qq.com>
…ymbols
The cherry-pick pulled in main's type-package migration (com.starrocks.type.*),
which does not exist on branch-3.5:
- FoldConstantsRule.java: remove the 7 duplicate com.starrocks.type.* imports
and revert BooleanType.BOOLEAN back to catalog Type.BOOLEAN.
- FoldConstantsRuleTest.java: VarcharType.VARCHAR -> Type.VARCHAR (catalog).
No behavior change to the LIKE escaping fix.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
StarRocks is compatible with MySQL 8, but WHERE-LIKE with constant items produces different results.
What I'm doing:
Add the 2nd-layer escape operator when FE handle the WHERE-LIKE with constant items.
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: