[Refactor] Remove obsolete config-name prefix compatibility in BE config parsing#75352
Merged
Merged
Conversation
Signed-off-by: trueeyu <lxhhust350@qq.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the BE config parsing path to remove legacy compatibility logic (stripping a doris_ prefix) and reduce overhead during config loading.
Changes:
- Removed
doris_prefix stripping inparse_key_value_pairs, so keys are looked up by their literal names. - Dropped the unused
<regex>include and regex-based replace logic. - Switched duplicate-config detection from
count(...) > 0tocontains(...).
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 685cc337f9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Contributor
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Contributor
[BE Incremental Coverage Report]✅ pass : 1 / 1 (100.00%) file detail
|
alvin-phoenix-ai
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
What I'm doing:
It's introduced in this pr: #8406
The BE config parser (
parse_key_value_pairs) carried legacy compatibility logic that stripped an obsolete name prefix from every config key before looking it up. The configs that relied on this prefix were renamed many versions ago and no longer exist inconfig.h, so the special-casing is dead code that adds a regex compile and a per-lineregex_replaceto config loading for no benefit.This PR removes the obsolete prefix-stripping logic so the parser looks up each key by its real name directly. It also drops the now-unused
<regex>include.What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: