[Refactor] Move snapshot to data_workflows#75383
Conversation
Signed-off-by: alvin-phoenix-ai <alvin.zhao@phoenixdata.ai>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
starrocks/be/src/data_workflows/snapshot/snapshot_loader.cpp
Lines 1 to 3 in 8a34c45
When moving this file, this header replaces the prior ASF/Doris attribution even though the implementation below is the same moved code with only include-path changes. For this refactor, dropping the upstream license notice from the C++ source (and the matching moved header) creates a license-compliance regression; keep the original ASF notice or carry it alongside the StarRocks header.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: alvin-phoenix-ai <alvin.zhao@phoenixdata.ai>
Why I'm doing:
What I'm doing:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: