Skip to content

[Refactor] Move snapshot to data_workflows#75383

Merged
alvin-phoenix-ai merged 2 commits into
StarRocks:mainfrom
alvin-phoenix-ai:opt-snapshot-1
Jun 26, 2026
Merged

[Refactor] Move snapshot to data_workflows#75383
alvin-phoenix-ai merged 2 commits into
StarRocks:mainfrom
alvin-phoenix-ai:opt-snapshot-1

Conversation

@alvin-phoenix-ai

Copy link
Copy Markdown
Contributor

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
    • This pr needs auto generate documentation
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 4.1
    • 4.0
    • 3.5

Signed-off-by: alvin-phoenix-ai <alvin.zhao@phoenixdata.ai>
@CelerData-Reviewer

Copy link
Copy Markdown

@codex review

@github-actions github-actions Bot requested review from srlch and xiangguangyxg June 26, 2026 01:26

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

// Copyright 2021-present StarRocks, Inc. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");

P2 Badge Restore ASF attribution on the moved snapshot loader

When moving this file, this header replaces the prior ASF/Doris attribution even though the implementation below is the same moved code with only include-path changes. For this refactor, dropping the upstream license notice from the C++ source (and the matching moved header) creates a license-compliance regression; keep the original ASF notice or carry it alongside the StarRocks header.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Signed-off-by: alvin-phoenix-ai <alvin.zhao@phoenixdata.ai>
@alvin-phoenix-ai alvin-phoenix-ai merged commit e711a55 into StarRocks:main Jun 26, 2026
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants