Skip to content

fix: polish native Windows paths#366

Open
raoabinav wants to merge 3 commits into
StarTrail-org:mainfrom
raoabinav:fix/windows-native-polish
Open

fix: polish native Windows paths#366
raoabinav wants to merge 3 commits into
StarTrail-org:mainfrom
raoabinav:fix/windows-native-polish

Conversation

@raoabinav
Copy link
Copy Markdown
Contributor

Evaluator Summary

  • Abi fixed native Windows portability issues in LEANN's chat and local-model integration paths, improving behavior outside Unix-like shells.
  • Design choice: the patch stays narrow and uses platform-native abstractions, replacing POSIX-only assumptions with os.pathsep for NODE_PATH and guarded timeout behavior where SIGALRM is unavailable.
  • The implementation also makes the CPU mkldnn.enabled setting type-checker-friendly, reducing platform-specific lint/type noise in embedding setup.
  • Quality bar: focused Windows and LM Studio tests passed locally, plus lint, format, type, lockfile, and whitespace checks; this is a clean supporting PR rather than a flagship roadmap feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant