refactor(context): extract recomposition input service#44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Recomposition input assembly now lives in
RecompositionInputService, soSessionRecompositionEnginecan focus on merge and full recomposition orchestration. The extracted service owns tail merged-record selection, immediate record loading, source metadata aggregation, CortexFS L2 hydration for merged tails, and orderedRecompositionEntryconstruction.The existing
ContextManagerand benchmark ingest wrapper boundaries are preserved. This keeps current callers stable while moving the record-preparation details out of the orchestration class.Validation
git diff --checkuv run --group dev ruff format --check .uv run --group dev ruff check .uv run --group dev pytest tests/test_recomposition_input.py tests/test_recomposition_engine.py tests/test_conversation_merge.py tests/test_context_manager.py tests/test_benchmark_ingest_service.py tests/test_benchmark_ingest_lifecycle.py -q