Skip to content

refactor(memory): isolate store write path from facade#70

Merged
HugoSkylight merged 1 commit into
masterfrom
refactor/store-mainline-facade-boundary-cleanup
May 4, 2026
Merged

refactor(memory): isolate store write path from facade#70
HugoSkylight merged 1 commit into
masterfrom
refactor/store-mainline-facade-boundary-cleanup

Conversation

@HugoSkylight

Copy link
Copy Markdown
Contributor

Summary

  • add explicit MemoryWriteDependencies assembled by CortexMemoryServices for the store write boundary
  • move store helper services off CortexMemory/MemoryService wrapper callbacks and onto MemoryWriteService dependencies
  • keep CortexMemory/MemoryService public compatibility wrappers and new bypass property access intact

Validation

  • uv run --group dev pytest tests/test_memory_store_record_service.py tests/test_memory_write_context_builder.py tests/test_memory_write_derive_service.py tests/test_memory_write_embed_service.py tests/test_memory_write_dedup_service.py tests/test_memory_directory_record_service.py tests/test_write_dedup.py tests/test_http_server.py tests/test_memory_document_write_service.py -q
  • uv run --group dev pytest tests/test_orchestrator_services.py tests/test_memory_service.py tests/test_knowledge_service.py tests/test_subsystem_bootstrapper.py tests/test_orchestrator_close.py -q
  • uv run --group dev pytest tests/test_memory_write_dedup_service.py tests/test_write_dedup.py -q
  • uv run --group dev ruff check src/opencortex/services/cortex_memory_services.py src/opencortex/services/memory_write_service.py src/opencortex/services/memory_service.py src/opencortex/services/memory_write_context_builder.py src/opencortex/services/memory_write_derive_service.py src/opencortex/services/memory_write_embed_service.py src/opencortex/services/memory_write_dedup_service.py src/opencortex/services/memory_directory_record_service.py src/opencortex/services/memory_store_record_service.py tests/test_memory_store_record_service.py tests/test_memory_write_context_builder.py tests/test_memory_write_dedup_service.py tests/test_memory_directory_record_service.py tests/test_orchestrator_services.py tests/test_memory_service.py
  • uv run --group dev ruff format --check src/opencortex/services/cortex_memory_services.py src/opencortex/services/memory_write_service.py src/opencortex/services/memory_service.py src/opencortex/services/memory_write_context_builder.py src/opencortex/services/memory_write_derive_service.py src/opencortex/services/memory_write_embed_service.py src/opencortex/services/memory_write_dedup_service.py src/opencortex/services/memory_directory_record_service.py src/opencortex/services/memory_store_record_service.py tests/test_memory_store_record_service.py tests/test_memory_write_context_builder.py tests/test_memory_write_dedup_service.py tests/test_memory_directory_record_service.py tests/test_orchestrator_services.py tests/test_memory_service.py

Browser

  • Not run: backend-only Python service/test diff with no browser route mapping.

@HugoSkylight
HugoSkylight merged commit e27523b into master May 4, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant