Skip to content

perf: report a daemon that is not ready yet as starting - #15

Merged
MattDHill merged 1 commit into
masterfrom
perf/ready-starting
Oct 16, 2026
Merged

MattDHill merged 1 commit into
masterfrom
perf/ready-starting

Conversation

@MattDHill

Copy link
Copy Markdown
Member

A daemon ready check that isn't satisfied yet now returns starting instead of loading, in the shared redisReady and mariadbReady helpers.

loading means operational but catching up, and start-sdk's default trigger re-polls it every 30 s. A sidecar that reported loading on an early probe therefore held every daemon requiring it for up to 30 s after it was ready. starting is re-polled every second. The pattern came from the packaging guide's Postgres example, corrected in Start9Labs/start-technologies#4272. Start9Labs/start-technologies#4273 makes the SDK back off loading instead, for packages that don't change.

No version bump: master's 16.51.1:0 isn't on beta yet, so this ships with it. Its release notes gain "Performance improvement".

Verified: tsc --noEmit, Prettier and make javascript/index.js pass. Not installed on a box.

🤖 Generated with Claude Code

A ready check that returns `loading` while its daemon is still coming up
is re-polled every 30 s under start-sdk's default trigger, so every
daemon that requires it waits up to 30 s after it is actually ready.
`starting` is re-polled every second.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@MattDHill
MattDHill requested a review from helix-a October 16, 2026 17:58

@helix-a helix-a left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The shared probes correctly return starting until ready, retaining their success criteria across normal startup, bootstrap/update, and password-reset chains. Confirmed the installed SDK polls starting every 1 second versus loading every 30 seconds. SDK 3.0.6 matches npm latest; beta still serves 16.51.0:0, so keeping 16.51.1:0 is appropriate.

Verified clean merge with master; local TypeScript, Prettier, JavaScript bundle, probe success/unready assertions, and SDK polling assertions pass. Reused successful x86_64 and aarch64 CI package builds. No runtime installation or startup timing measurement performed. No changes requested.

Helix-Harness: pi
Helix-Model: openai-codex/gpt-6.1-sol

@MattDHill
MattDHill merged commit 5e4b758 into master Oct 16, 2026
3 checks passed
@MattDHill
MattDHill deleted the perf/ready-starting branch October 16, 2026 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants