Skip to content

Proposal for adding local filepath support #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
little-fort wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Proposal for adding local filepath support #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b962fe3
Add task inputs to support local file usage
Jun 18, 2021
2d4b8be
Add logic to set filepath based on configured location
Jun 18, 2021
ce53964
Add missing 'required' attribute for modified props
Jun 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions task/precodesigning.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,18 @@ async function run(): Promise<void> {
let secureFileHelper: sec.SecureFileDownloader = new sec.SecureFileDownloader();
try {
tl.setResourcePath(path.join(__dirname, "task.json"));

let secureFilePath: string;
let secureFileLocation: string = tl.getInput("secureFileLocation", true);
if (secureFileLocation == "azure") {
secureFileId = tl.getInput("secureFileId", true);
secureFilePath = await secureFileHelper.downloadSecureFile(secureFileId);
}
else if (secureFileLocation == "filepath")
secureFilePath = tl.getInput("secureFileLocalPath", true);
else
throw "The configured secure file location is invalid."

secureFileId = tl.getInput("secureFileId", true);
let secureFilePath: string = await secureFileHelper.downloadSecureFile(secureFileId);
tl.setTaskVariable("SECURE_FILE_PATH", secureFilePath);
} catch (err) {
tl.setResult(tl.TaskResult.Failed, err);
Expand Down
24 changes: 23 additions & 1 deletion task/task.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,36 @@
"minimumAgentVersion": "2.116.0",
"instanceNameFormat": "Code Signing $(filePath)",
"inputs": [
{
"name": "secureFileLocation",
"type": "radio",
"label": "Secure File Location",
"helpMarkDown": "Indicates where the secure file is located. Certificate can either be retrieved from the project's secure files library or a specific filesystem path on the build machine.",
"required": true,
"defaultValue": "azure",
"options": {
"azure": "Azure secure files library",
"filepath": "Local filepath"
}
},
{
"name": "secureFileId",
"type": "secureFile",
"label": "Secure File",
"defaultValue": "",
"required": true,
"required": false,
"visibleRule": "secureFileLocation = azure",
"helpMarkDown": "Select the certificate that was uploaded to `Secure Files` to be used to sign the given files."
},
{
"name": "secureFileLocalPath",
"type": "string",
"label": "Secure File Path",
"defaultValue": "",
"required": false,
"visibleRule": "secureFileLocation = filepath",
"helpMarkDown": "Enter the filepath of the certificate to be used to sign the given files."
},
{
"name": "signCertPassword",
"type": "string",
Expand Down