refactor: standardize admin management accessors and replace direct R…#226
Merged
Merged
Conversation
…esult unwrap calls with robust error handling in liquidity calculations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #211
Pull Request: Add Time-Weighted Average Price (TWAP) Accumulator
Summary
This PR introduces a Time-Weighted Average Price (TWAP) accumulator to the counter contract, providing a manipulation-resistant pricing mechanism for consumers such as limit orders, risk checks, and analytics. Instead of relying solely on the latest spot price, the contract now maintains historical observations and computes an average price over a configurable time window.
As part of this work, the test environment was also restored by fixing existing compilation issues in unrelated test modules, allowing the complete test suite to run successfully.
Changes
✨ New
counter/src/twap.rsimplementing the TWAP accumulator.get_twap(env, pair, window_seconds) -> i128for querying the time-weighted average price.twap_tests.rs.🔄 Updated
lib.rstwapmodule.get_twapcontract method.oracle.rstwap::update_twap()into the price update flow so oracle price updates are recorded automatically.liquidity_pool.rs🛠 Test Environment Fixes
governance_tests.rsLedgertest utility import required for timestamp manipulation.risk_management_tests.rsLedgerimport.Testing
Added unit tests covering:
Acceptance Criteria
get_twapreturns the correct average across multiple observations.