Add networkId to stellar configuration#202
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA single field, ChangesStellar networkId config field
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
ritik4ever
left a comment
There was a problem hiding this comment.
Thanks for the contribution! Adding stellar.networkId to the configuration is a useful first step, but by itself it doesn't fully resolve Issue #131.
The hardcoded network strings in the x402 signer/payment flow still need to be replaced with configuration-driven values, and the remaining requirements from the issue (startup validation, env documentation updates, related call-site updates, etc.) are not included in this PR.
Could you please expand the implementation to cover the full issue requirements, or alternatively narrow the PR scope and open a separate issue for the remaining work?
Closes #131
'stellar:testnet'as the network string for the x402 signer, instead ofreading it from config. This meant deploying Lodestar to mainnet would
silently keep signing with the testnet network ID, causing a network
mismatch that surfaced only as a generic 402 failure.
backend/src/config.js**: addedstellar.networkId, a derived value(
stellar:${STELLAR_NETWORK}) built from the existingSTELLAR_NETWORKenv var. Kept
stellar.network(baretestnet/mainnet) unchanged forexisting consumers.
Summary by CodeRabbit