feat(contracts): add creator-controlled invoice pause mechanism#170
Merged
Kingsman-99 merged 3 commits intoJun 20, 2026
Merged
Conversation
Implements pause_invoice, resume_invoice, and admin_force_resume entry points with lazy auto-resume in _pay. Also fixes compilation errors left by the merged rate-limiter PR (Stellar-split#168): missing fields, storage keys, broken From impls, and incorrect test call sites. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ct reference Vec::new(&Env::default()) creates objects bound to a throwaway host; passing them to a contract call on a different env caused the Soroban "mis-tagged object reference" panic in all four rate-limiter tests. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
11 tasks
Kingsman-99
added a commit
that referenced
this pull request
Jun 24, 2026
… break PR #170 added pause_reason/auto_resume_at/payment_cooldown_secs/ max_payments_per_window/payment_window_secs to Invoice but never wired them into InvoiceExt/split()/assemble(), and called three events::invoice_* functions that were never defined. Both are now fixed. Also fixes CloneOverrides.new_overflow_behavior: Option<OverflowBehavior> can never compile in a #[contracttype] struct (plain enums only get a fallible TryFrom<ScVal>, not the infallible From that Option<T> requires). Switched to Vec<OverflowBehavior> (0/1 elements), matching split-sdk's client.ts wire format update. Removed two unused dead-code helpers (save_invoice_ext/load_invoice_ext). cargo build and cargo test (144/144) now pass clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #164