feat: throw ConnectionRefusedError when ECONNREFUSED is detected#659
Open
Dwifax wants to merge 1 commit into
Open
feat: throw ConnectionRefusedError when ECONNREFUSED is detected#659Dwifax wants to merge 1 commit into
Dwifax wants to merge 1 commit into
Conversation
Detect ECONNREFUSED in fetch error cause chain and throw a
specific ConnectionRefusedError instead of a generic NetworkError.
This gives users a clear 'Is the backend running?' hint when
the Stellar Explain server is not reachable.
- Add ConnectionRefusedError to errors.ts
- Detect cause.message.includes('ECONNREFUSED') in client.ts
- Add 2 tests: ECONNREFUSED → ConnectionRefusedError, ENOTFOUND → NetworkError fallthrough
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the Stellar Explain backend is down or unreachable, Node.js fetch throws a
TypeErrorwithcause.messagecontaining "ECONNREFUSED". Previously this was caught by the genericNetworkErrorfallback, giving users a confusing "Request failed: fetch failed" message with no hint about the root cause.This PR adds a specific
ConnectionRefusedErrorthat clearly tells users:Changes
errors.ts: NewConnectionRefusedErrorclass withEXIT_CODE.ERRORclient.ts: DetectECONNREFUSEDincause.messagebefore falling through to genericNetworkErrorclient.test.ts: 2 new tests:ECONNREFUSED→ConnectionRefusedError✓ENOTFOUND→NetworkErrorfallthrough ✓Test Results