Skip to content

feat: add cli-v2 integration tests for validate, inspect, compare, convert#420

Merged
Tinna23 merged 1 commit into
StellarCommons:mainfrom
mogbonjubolaolasunkanmi-art:feat/issues-404-405-406-407
Jul 2, 2026
Merged

feat: add cli-v2 integration tests for validate, inspect, compare, convert#420
Tinna23 merged 1 commit into
StellarCommons:mainfrom
mogbonjubolaolasunkanmi-art:feat/issues-404-405-406-407

Conversation

@mogbonjubolaolasunkanmi-art

Copy link
Copy Markdown
Contributor

Summary

Adds four integration test files for the devkit cli-v2 subcommands as described in the assigned issues.

Files added

What each test suite covers

cli_validate (#404): Runs devkit validate on clean and dirty fee CSV files, asserts exit codes and output messages (header check, column count, non-numeric fee rejection, empty input, determinism).

cli_inspect (#405): Runs devkit inspect on a known seeded fee file; asserts percentile table values (p25/median/p75/p95/p99 ordering), min/max, mean within range, spike fees exceed base, sequential timestamps.

cli_compare (#406): Creates two synthetic fee files (low-fee quiet vs high-fee congested), runs compare, asserts delta values: mean_diff is negative, mean_diff_pct direction, manually computed exact deltas, identical-dataset diff = 0.

cli_convert (#407): Converts a CSV to JSON and back; asserts round-trip produces identical records for both CSV↔points and JSON↔points, including spike-flag preservation.

Testing

All 42 tests pass locally with zero warnings:

test result: ok. 9 passed; 0 failed  (cli_validate)
test result: ok. 11 passed; 0 failed (cli_inspect)
test result: ok. 11 passed; 0 failed (cli_compare)
test result: ok. 11 passed; 0 failed (cli_convert)

Closes #404
Closes #405
Closes #406
Closes #407

@drips-wave

drips-wave Bot commented Jun 30, 2026

Copy link
Copy Markdown

@mogbonjubolaolasunkanmi-art Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Tinna23 Tinna23 merged commit 540f8af into StellarCommons:main Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants