feat: add cli-v2 integration tests for validate, inspect, compare, convert#420
Merged
Tinna23 merged 1 commit intoJul 2, 2026
Conversation
…nvert (closes StellarCommons#404, closes StellarCommons#405, closes StellarCommons#406, closes StellarCommons#407)
|
@mogbonjubolaolasunkanmi-art Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds four integration test files for the devkit
cli-v2subcommands as described in the assigned issues.Files added
packages/devkit/tests/cli_validate.rs— 9 tests (issue [devkit/cli-v2] Write integration test for validate subcommand #404)packages/devkit/tests/cli_inspect.rs— 11 tests (issue [devkit/cli-v2] Write integration test for inspect subcommand #405)packages/devkit/tests/cli_compare.rs— 11 tests (issue [devkit/cli-v2] Write integration test for compare subcommand #406)packages/devkit/tests/cli_convert.rs— 11 tests (issue [devkit/cli-v2] Write integration test for convert subcommand #407)What each test suite covers
cli_validate (#404): Runs
devkit validateon clean and dirty fee CSV files, asserts exit codes and output messages (header check, column count, non-numeric fee rejection, empty input, determinism).cli_inspect (#405): Runs
devkit inspecton a known seeded fee file; asserts percentile table values (p25/median/p75/p95/p99 ordering), min/max, mean within range, spike fees exceed base, sequential timestamps.cli_compare (#406): Creates two synthetic fee files (low-fee quiet vs high-fee congested), runs compare, asserts delta values: mean_diff is negative, mean_diff_pct direction, manually computed exact deltas, identical-dataset diff = 0.
cli_convert (#407): Converts a CSV to JSON and back; asserts round-trip produces identical records for both CSV↔points and JSON↔points, including spike-flag preservation.
Testing
All 42 tests pass locally with zero warnings:
Closes #404
Closes #405
Closes #406
Closes #407