perf: reusable prepared statements for telemetry inserts#555
Open
Meet-hybrid wants to merge 1 commit into
Open
perf: reusable prepared statements for telemetry inserts#555Meet-hybrid wants to merge 1 commit into
Meet-hybrid wants to merge 1 commit into
Conversation
Create src/database/writer.py — a DatabaseWriter that pre-compiles INSERT statements once per (table, column-set) pair and reuses them across all batch writes, eliminating repeated SQL parsing overhead. - DatabaseWriter caches compiled INSERT SQL keyed by (table, *columns) - Uses psycopg2.sql.SQL + sql.Identifier for safe PostgreSQL composition - Uses executemany for both SQLite and PostgreSQL backends - Refactors BatchSink._flush to delegate to DatabaseWriter.insert_batch - Refactors LatencyTracker.flush to replace row-by-row cursor.execute with a single executemany call per flush cycle - All existing latency tracker tests pass (4/4)
|
@Meet-hybrid Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create src/database/writer.py — a DatabaseWriter that pre-compiles INSERT statements once per (table, column-set) pair and reuses them across all batch writes, eliminating repeated SQL parsing overhead.
Closes #482