feat: dynamically resolve share_decimals from asset decimals (fixes #66)#736
Open
david87131 wants to merge 1 commit into
Open
feat: dynamically resolve share_decimals from asset decimals (fixes #66)#736david87131 wants to merge 1 commit into
david87131 wants to merge 1 commit into
Conversation
…tellarYield#66) - Retrieve underlying asset decimals via SEP-41 decimals() query in vault factory creation - Fix compile errors and failing lockup/shortfall tests in single_rwa_vault contract
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #66.
Changes:
_create_single_rwa_vault) to query the actual token decimals of the underlying asset (vault_asset) using the SEP-41decimals()query.share_decimalsdynamically insideSingleRwaVaultInitParamswith the retrieved value instead of hardcoding it to6.single_rwa_vaulttest suite (includingtest_lock_upcalling activate before deposit and incorrect panic error check).