-
-
Notifications
You must be signed in to change notification settings - Fork 875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modelling motions of binary star system #4095
Conversation
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
This is an automatically generated QA checklist based on modified files. |
Great stuff! But probably #4076 should be 100% fixed before adding this. γ Vir is another nice double. For a catalog, this looks promising: http://www.astro.gsu.edu/wds/orb6.html |
Damn, I don't have access to WDS catalog anymore O_o Yes, adding full support WDS catalog is possible now and probably it should be adding via 2 files - one file for known orbital elements of binaries (multiple systems) and one file for cross identification and informational data (likewise a currect HIP subset of WDS). |
Thanks for noticing the inconsistency! Motion of the barycenter is taken into account already but a problem on normalized vector caused the error in position. Now I have fixed the issue and added γ Vir. |
I've seen some stars that should be modelled as double stars (I'm not sure if they have defined orbits, though). I simply based this on looking at what stars fly apart in the future or past.
|
I have fixed the parameters so 61 Cyg should match the HiPS layer now.
Thanks for the list.
|
Would it be possible to visualize the orbit, just like planet orbits? And maybe even have markers on it (point of visual/actual apo-/periastron, perhaps markings for dates)? |
This is maybe helpful:
Maybe adding some catalog of orbital data will be good solution (reading data from this catalog and use it for computations)? |
Yes, definitely. Even if the list is short now, but inlining every star like that is not elegant. Of course, an extended list means suppressing their "standard" entries in the default star catalog. |
I've made some progress on putting the list in a separate data file! I don't have much time tonight to test but I think the binary stars are still working properly. |
Great. It really looks fabulous, and I hope this can still go into 25.1 if finished soon. (Needs to be done before RC1!) |
With the latest commits to |
OK, I've uploading new part of catalog on GH at the moment P.S. @henrysky, I moved you into core team 2 days ago - you can push fixes and small changes direct into |
Neat! I found Castor also has a stationary component. Other than that, I have not found any others. |
Castor has been added and I think this PR is ready to be reviewed and merged. There is still one problem where for example, search |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
I wonder why 61 Cyg B carries the labels like "Bessel's star". Should be either the whole system, or just the brighter component A, right? |
yes, IMHO
Inner dictionary for double stars |
double dec = 0.; | ||
getBinaryOrbit(epoch, v, ra, dec, plx, pmra, pmdec, rv); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add some literature documentation here, where you found the algorithms? Maybe Explanatory Supplement (which ed), some other book dedicated on double stars? Or did you do all the math yourself from scratch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I end up just do most of the math myself from definitions of these orbital elements. From the definitions, one can compute the 2D orbit of the secondary star in the reference frame of the primary and then rotate the 2D orbital plane to 3D orbit as seen on the sky and then apply proper motion to the barycenter of the binary star. No fancy algorithms used here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, maybe not really fancy and can be done by oneself, but I had expected you followed some textbook, so congratulations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok, let me google to see if there is any good material on those. I forget which resources I use as I indeed have looked up what those orbital elements mean exactly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from a bibliography note which I just feel should be there and should not cost much time to add, I won't object a merge. The result just looks awesome, congratulations! When finalizing SUG changes I may edit a bit, but thanks also for these edits and additions.
You can use TAP query on SIMBAD to query parents/children, for example querying
And parent of exoplanet
I don't think it can be done by SIMBAD scripting. Or as Alex mentioned just do a dictionary to quickly fix known ones. |
I don't mean our casual users should be asked to do SQL queries. They would want to enter "61 Cyg" and expect to find what is now returned only when you know you have to search for "61 Cyg A", i.e., HIP 104214, not a custom object. @alex-w said "Inner dictionary for double stars", but that is still vague. Which file to add "61 Cyg"? |
This file is not exist yet. I've proposed one of solution to resolve objects like multiple stars - select first component when short form of designation is used. |
I meant to say currently Stellarium is using SIMABD scripting interface to query object name (see #3980 that I improve a while ago). So if an object name is resolved and not in stellarium, it is possible that we use TAP query to check if their parent/child is in Stellarium for user (I Don't mean for user to do SQL queries themselves). |
A working but dirty way would be to handle a handful of such commonplace star names like 61 Cyg as proper name in the current skyculture. (I think this was a year ago?) |
Why? Just editing |
OK if that works. Just you said above such "inner dictionary" file does not exist. Is it OK to assign two names ("61 Cyg" and "61 Cyg A") to one star here? |
It is in master already - just check it (I've added short designations for double stars today) :) |
OK, I switched off SIMBAD lookup. But I was lazy, typing "61 cyg" is not enough. "61 Cyg" worked. maybe search should compare any capitalisation here. |
No. How you will resolve j Cen and J Cen for example? |
Another find: Compare location of 61 Cyg in 2MASS HiPS. I thought that was taken around 2000? @henrysky is proper motion off? In the DSS, 61Cyg fits to 1975, when the DSS plates are from 1983-2006. |
Good point. You could just offer both to choose from, though. |
Hello @henrysky! Please check the fresh version (development snapshot) of Stellarium: |
Hello @henrysky! Please check the latest stable version of Stellarium: |
I have added support to model motions of binary star system as seen on the sky and their 6D astrometry (RA, DEC, PMRA, PMDEC, PLX, RV).
So far I have only manually added Alpha Centauri A/B, Sirius A/B and 61 Cygni A/B. In order to model a binary system we need:
At least for Alpha Centauri A/B and Sirius A/B, the motion on the sky as well as radial velocity matched really well to past observations (https://iopscience.iop.org/article/10.3847/1538-3881/abfaff/pdf, https://arxiv.org/pdf/1703.10625).
If there are other binary systems you want to model, I can try to find all the required orbital parameters and add them manually before we figure it out a way to model a large amount of binary stars if possible.
Fixes #353
Screenshots (if appropriate):
An example of Sirius A/B with parallax disabled to avoid confusion:
Untitled.mov
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: