Use hips_frame and type to determine planet #4170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
gzotti
reviewed
Mar 2, 2025
| @@ -61,7 +61,7 @@ class HipsSurvey : public QObject | |||
| //! Create a new HipsSurvey from its url. | |||
| //! @param url The location of the survey. | |||
| //! @param releaseDate If known the UTC JD release date of the survey. Used for cache busting. | |||
There was a problem hiding this comment.
param type must be explained here.
10110111
force-pushed
the
hips-planet-name
branch
from
a1ea3b2 to
8633cc0
Compare
alex-w
added
the
state: published
|
Hello @10110111! Please check the fresh version (development snapshot) of Stellarium: |
alex-w
removed
the
state: published
|
Hello @10110111! Please check the latest stable version of Stellarium: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current way of determining planet—by reading the filename of survey's URL—is quite hacky and doesn't let one find other survey components related to the same planet, e.g. the normal map. At the same time, all the planet HiPS currently available have properties that determine them as planetary, which planet they are for, and what type of map they represent.
So this PR uses these properties to determine planet.
Checklist: