Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for normal and horizon maps in planetary HiPS #4177

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

10110111
Copy link
Contributor

@10110111 10110111 commented Mar 5, 2025

Description

This automatically adds the normal and horizon map surveys for a planet to the corresponding planet object, and these map surveys are passed to the albedo survey.

One limitation that I don't think is worth the trouble lifting is that if a normal or horizon map is present but has hips_order smaller than that of the albedo survey, the total order of the HiPS is reduced to the smallest of them. Particularly, with our data.stellarium.org/surveys/moon-normal this yields max order 2 instead of 3.

In the future I'm planning to add my versions of the Moon surveys, including all the items: albedo, normals, horizons, which will yield a better version of the current static Moon.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • Housekeeping

How Has This Been Tested?

Test Configuration:

  • Operating system: Ubuntu 20.04
  • Graphics Card: Intel UHD Graphics 620

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

github-actions bot commented Mar 5, 2025

Great PR! Please pay attention to the following items before merging:

Files matching src/**/*.cpp:

  • Are possibly unused includes removed?

This is an automatically generated QA checklist based on modified files.

@alex-w alex-w added this to the 25.1 milestone Mar 5, 2025
Copy link
Member

@gzotti gzotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This view becomes addictive :-)

@10110111 10110111 merged commit 5cfb72a into Stellarium:master Mar 6, 2025
15 checks passed
@10110111 10110111 deleted the hips-normal-texture branch March 6, 2025 01:09
@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Mar 9, 2025
Copy link

github-actions bot commented Mar 9, 2025

Hello @10110111!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Mar 23, 2025
Copy link

Hello @10110111!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants