Use real native Chinese names in SC index.json

[10110111]

This is a result of fetching all the constellation names from constellation_names.zh_CN.fab into index.json, yielding native names made of hieroglyphs and "pronounce" entries made of (diacriticless) pinyin.

[10110111]

@sunshuwei You may want to review this too.

[github-actions]

Great PR! Please pay attention to the following items before merging:

Files matching skycultures/**:

• Did you remember to update skycultures/CMakeLists.txt file respectively to changes in sky cultures?
• Did you remember to define classification parameter in sky cultures (see index.json file)?
• Did you remember to define license parameter in sky cultures (see description.md file)?
• Did you remember to define region parameter in sky culture (see index.json file)?

This is an automatically generated QA checklist based on modified files.

[gzotti]

Not being an expert on pinyin. Do we have diacritics in one, and non-diacritics in the other SC, or do we have unhealthy mixes now?

[10110111]

Do we have diacritics in one, and non-diacritics in the other SC, or do we have unhealthy mixes now?

We have diacritics in some names of the same SC (DSO, stars) and no diacritics in others (constellations, planets). So I'd call it an unhealthy mix.

[sunshuwei]

The diacritical mark is used to distinguish tones. In the Pinyin standard, as a transliterated vocabulary, it does not have diacritical marks, but as a strict phonetic notation, it has diacritical marks.
The constellation names were originally incorporated as native terms, hence their lack of diacritical marks.
In Chinese sky culture, the pinyin of star names was originally added as phonetic symbols, so there are diacritical marks.
Because at that time, constellations had native terms but no pronunciation terms, and stars did not have native terms.
Just didn't anticipate the current changes. If necessary, I can add all diacritical marks in the future.

[gzotti]

This would be great. Yes, the project and data options have grown a lot. Ruslan and Fabien started using JSON with Stellarium-mobile years ago and added the "pronounce" key, while I had expected or preferred a "transliteration" key, while for "pronounce" I would have expected IPA annotation. There are other cases where both transliteration and pronounce and even IPA would be great. I know for Tibetan, scientists use Wylie which is not really a pronunciation help, and there is a pinyin for Tibetan as well. So, in the end we may fill tags "pronunciation" (for Chinese: "pinyin with diacritics"), transliteration (pinyin without), and "IPA" for international phonetic alphabet, if anyone can add that correctly. But these tags will not be used in 25.1 now. If you can later help filling the gaps, it would be welcome.

[alex-w]

What about modern_chinese - should it have native names too?

[gzotti]

Yes, sure. native=Chinese glyphs, pronunciate=pinyin (cannot say which flavour is best, but please consistent), english=translation. I understand there are less glyphs in use, but this is for SC authors to fill.

[alex-w]

@gzotti and @sushoff please review the PR

[gzotti]

Just any random pick here: The "english" entry should be the translated only. The other "english" entry which is now filled with pinyin should be renamed "pronounce".

[gzotti]

In this list, obviously, the pronounce entries in pinyin are missing.

[gzotti]

@10110111 What happens if there are two english entries in a star entry? One is the translation, the other pinyin. (should be renamed to pronounce, obviously) Random pick, or are they combined, or does the second overwrite the first?

[10110111]

What happens if there are two english entries in a star entry?

It's not portable, lets note this first. Qt doesn't seem to document its own behavior on which entry it picks either. This only works for our comments because we never pick them.

[gzotti]

OK, I have fixed the medieval. The Chinese has over 3000 star entries like

    "HIP 79540": [{"english": "Punishment Added III", "native": "罚增三", "references": [1]},
                  {"english": "Fá zēng III", "references": [1], "translators_comments": "Pinyin transliteration"}],

that need to be reformatted into

    "HIP 79540": [{"english": "Punishment Added III", "native": "罚增三", 
                  "pronounce": "Fá zēng III", "references": [1], "translators_comments": "Pinyin transliteration"}],

A few stars have double naming. Sorry, I am not touching this file. Experts please! @sunshuwei ?

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.