Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce HiPS split order when tile width is small #4220

Merged
merged 1 commit into from
Mar 18, 2025
Merged

Conversation

10110111
Copy link
Contributor

Some AKARI surveys appear to have hips_tile_width=32, which is much smaller than the default 512. This means that a FullHD screen will have roughly 2000 tiles shown, each of which would be split according to splitOrder computed. Thus, to achieve a level of splitting similar to the normal case of 512px tiles we should reduce splitOrder according to the log2(tileWidth/512).

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • Housekeeping

How Has This Been Tested?

Test Configuration:

  • Operating system: Ubuntu 20.04
  • Graphics Card: Intel UHD Graphics 620

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Some AKARI surveys appear to have hips_tile_width=32, which is much
smaller than the default 512. This means that a FullHD screen will have
roughly 2000 tiles shown, each of which would be split according to
splitOrder computed. Thus, to achieve a level of splitting similar to
the normal case of 512px tiles we should reduce splitOrder according to
the log2(tileWidth/512).
Copy link

Great PR! Please pay attention to the following items before merging:

Files matching src/**/*.cpp:

  • Are possibly unused includes removed?

This is an automatically generated QA checklist based on modified files.

Copy link
Member

@alex-w alex-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@alex-w alex-w added this to the 25.1 milestone Mar 17, 2025
Copy link
Member

@gzotti gzotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. It's still at 8fps or so, but better than 1.7fps.

@10110111 10110111 merged commit 5d349d4 into master Mar 18, 2025
30 checks passed
@10110111 10110111 deleted the small-tile-hips branch March 18, 2025 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants