Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix accents in a JSON snippet #4226

Merged
merged 2 commits into from
Mar 19, 2025
Merged

Fix accents in a JSON snippet #4226

merged 2 commits into from
Mar 19, 2025

Conversation

10110111
Copy link
Contributor

I think it's better to include the accents than to apologize. Additionally, the JSON data have been updated to match the latest version of the SC.

@github-actions github-actions bot requested review from alex-w and gzotti March 19, 2025 04:50
@github-actions GitHub Actions
Copy link

Great PR! Please pay attention to the following items before merging:

Files matching guide/**:

  • Did you remember to update screenshots to match new updates?
  • Did you remember to grammar check in changed part of documentation?

This is an automatically generated QA checklist based on modified files.

@alex-w alex-w added this to the 25.1 milestone Mar 19, 2025
@alex-w alex-w added the documentation Improvements or additions to documentation label Mar 19, 2025
gzotti
gzotti approved these changes Mar 19, 2025
View reviewed changes
Copy link
Member

@gzotti gzotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for finding this solution, yes!

@alex-w alex-w merged commit 58498c7 into master Mar 19, 2025
28 checks passed
@alex-w alex-w deleted the sc-conv-documentation branch March 19, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-w alex-w alex-w approved these changes

@gzotti gzotti gzotti approved these changes

Assignees

@10110111 10110111

Labels
documentation Improvements or additions to documentation
Milestone
25.1
Development

Successfully merging this pull request may close these issues.
3 participants
@10110111 @alex-w @gzotti