Add padding to bounding cap to avoid clipping on small FOV #4231
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add padding to bounding cap to avoid clipping on small FOV. The root cause is Saemundsson's inversion formula for atmospheric refraction is not exact as stated in
stellarium/src/core/RefractionExtinction.cpp
Line 253 in 8a129b6
0.5 arcmin padding seems to work well except a few arcminute above the horizon (which is really close and I think this is good enough).
Fixes #365, #538
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: