fix(payroll): use checked arithmetic for cumulative milestone total (#502)#691
Closed
jjb9707 wants to merge 4 commits into
Closed
fix(payroll): use checked arithmetic for cumulative milestone total (#502)#691jjb9707 wants to merge 4 commits into
jjb9707 wants to merge 4 commits into
Conversation
…tellopay#502) Cumulative milestone total in `add_milestone` was computed with a raw `total + amount` that could silently wrap `i128` on maliciously large inputs. Switch to `checked_add` and reject with a new `PayrollError::MilestoneTotalOverflow` (code 44) on overflow.
Contributor
|
Closing since this PR isn't linked to an issue you're assigned to. Please get assigned to an open issue first, then feel free to open a fresh PR referencing it. Thanks for understanding! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #502
add_milestoneaccumulatedMilestoneKey::TotalAmountwith a rawtotal + amount, which can silently wrapi128if a caller supplies a largeamountwhile the running total is near the type bound.Changes
total + amountwithtotal.checked_add(amount).ok_or(PayrollError::MilestoneTotalOverflow)?inadd_milestonePayrollError::MilestoneTotalOverflow = 44to the error enum (append-only)new_totalSecurity
Prevents a silent integer wrap of the cumulative milestone total, keeping escrow accounting consistent with the per-milestone sums asserted in debug builds.