Skip to content

fixed repeater task bugs #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VioletLiGonzales wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fixed repeater task bugs #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca0bc03
fixed repeater task bugs
Aug 4, 2023
a4f26c0
fixed comment
Aug 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions RepeaterTask.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,8 @@ void RepeaterTask::InterruptRxData()
protocolRxBuffer[protocolMsgIdx++] = '\0';
isProtocolMsgReady = true;

// Notify the protocol task
Command cm(PROTOCOL_COMMAND, EVENT_PROTOCOL_RX_COMPLETE);
// Notify the repeater task
Command cm(PROTOCOL_COMMAND, REPEATER_TASK_COMMANDS::EVENT_REPEATER_RX_COMPLETE);
bool res = qEvtQueue->SendFromISR(cm);

// If we failed to send the event, we should reset the buffer, that way ProtocolTask doesn't stall
Expand Down
2 changes: 1 addition & 1 deletion RepeaterTask.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ class RepeaterTask : public Task

inline void RepeaterTask::SendData(uint8_t* data, uint16_t size)
{
Command cm;
Command cm(DATA_COMMAND, uartTaskCommand);
cm.CopyDataToCommand(data, size);

// Send it to the UART task using the task's registered uartTaskCommand
Expand Down