[Bugfix:Autograding] add csci1200 container & update drmemory bin64 path #5883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5883 +/- ##
=========================================
Coverage 22.26% 22.26%
Complexity 6269 6269
=========================================
Files 157 157
Lines 20532 20532
=========================================
Hits 4572 4572
Misses 15960 15960
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
merging these changes into PR #5926 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Submitty/Tutorial#32
we need to add the csci1200 container to the vagrant install....
And, the drmemory path has been wrong for a while (now we should use the bin64 version by default)
this PR is work in progress
While for tutorial 02_simple_cpp the container works great..
for 05_cpp_static_analysis we are apparently missing the static analysis module from the docker container.
and for 08_memory_debugging something is wrong with the drmemory install. valgrind works fine, but drmemory complains about a bad system call. I tried adding everything/all system calls to the allowed list but it still had the bad system call error. I've seen that before and wasn't able to track down the problem. So I'm worried that's an incorrect error message? The new 08_memory_debugging works fine if you comment out the container. No extra system call whitelist necessary.
maybe it's a path location problem for drmemory in the csci1200 container?
Before merging this PR, we should merge
Submitty/Tutorial#32
and update the required minimum tutorial version number.