-
Notifications
You must be signed in to change notification settings - Fork 56
[UI/UX:System] Dark Mode Toggle #691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Still very rough around the edges but dark mode is officially toggleable
Dark mode now toggles with a 200ms transition time. TODO: Tidy up using CSS variables and not hard coding. Swap any images/icons or things that don't contrast well with dark mode. Style the button to be a nice clean slider. Make sure button placement is clean on mobile, unsure of how to implement that but will figure it out.
Now includes a toggle in the sidebar.
When you reloaded the page in dark mode, it would flash white. This shouldn't happen anymore. Additionally, the no src error should be eliminated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like how this was implemented, I think the toggle should go under the submitty logo personally but we agreed on the current location in the meeting. Oherwise this PR is good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please don't delete the 4 color seal. the blue chevrons in the RPI seal inspired the blue chevrons in the submitty logo.
Now uses the original image, but instead of the image being transparent, it has a white background.
…ty.github.io into dark-mode-toggle
What's new?
_colors.scss
so that colors can change dynamically.video.for.sub.docs.site.mp4