Skip to content

cloudwatchlogs-with-dlq: support optional kms key for encrypting sns topics #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

cloudwatchlogs-with-dlq: support optional kms key for encrypting sns topics #202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion cloudwatchlogs-with-dlq/DLQLambdaCloudFormation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@
"Default": "[email protected]",
"Description": "Enter your email for receiving alerts.You will receive confirmation email after the deployment is complete, confirm it to subscribe for alerts."
},
"SNSTopicKMSKey": {
"Type": "String",
"Default": "",
"Description": "Optional KMS key id to encrypt messages on the email SNS topic."
},
"NumOfWorkers": {
"Type": "Number",
"Default": 4,
Expand Down Expand Up @@ -63,6 +68,9 @@
"ap-southeast-3": {"bucketname": "appdevzipfiles-ap-southeast-3"}
}
},
"Conditions": {
"HasSNSTopicKey": { "Fn::Not": [ { "Fn::Equals": [ { "Ref": "SNSTopicKMSKey" }, "" ] } ] }
},
"Resources": {
"SumoCWLogGroup": {
"Type": "AWS::Logs::LogGroup",
Expand Down Expand Up @@ -322,7 +330,8 @@
"Subscription":[ {
"Endpoint" : {"Ref": "EmailID"},
"Protocol" : "email"
}]
}],
"KmsMasterKeyId": { "Fn::If" : [ "HasSNSTopicKey", { "Ref": "SNSTopicKMSKey" }, { "Ref": "AWS::NoValue" } ] }
}
},
"SumoCWSpilloverAlarm":{
Expand Down
11 changes: 10 additions & 1 deletion cloudwatchlogs-with-dlq/DLQLambdaCloudFormationWithSecuredEndpoint.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@
"Default": "[email protected]",
"Description": "Enter your email for receiving alerts.You will receive confirmation email after the deployment is complete, confirm it to subscribe for alerts."
},
"SNSTopicKMSKey": {
"Type": "String",
"Default": "",
"Description": "Optional KMS key id to encrypt messages on the email SNS topic."
},
"NumOfWorkers": {
"Type": "Number",
"Default": 4,
Expand Down Expand Up @@ -63,6 +68,9 @@
"ap-southeast-3": {"bucketname": "appdevzipfiles-ap-southeast-3"}
}
},
"Conditions": {
"HasSNSTopicKey": { "Fn::Not": [ { "Fn::Equals": [ { "Ref": "SNSTopicKMSKey" }, "" ] } ] }
},
"Resources": {
"SumoCWLogGroup": {
"Type": "AWS::Logs::LogGroup",
Expand Down Expand Up @@ -362,7 +370,8 @@
"Subscription":[ {
"Endpoint" : {"Ref": "EmailID"},
"Protocol" : "email"
}]
}],
"KmsMasterKeyId": { "Fn::If" : [ "HasSNSTopicKey", { "Ref": "SNSTopicKMSKey" }, { "Ref": "AWS::NoValue" } ] }
}
},
"SumoCWSpilloverAlarm":{
Expand Down