Update deploy-to-pantheon.yml #5681
Conversation
There was a problem hiding this comment.
Hi @vfalconisumo, before we merge, I'd like to discuss this fork and its implications.
| uses: pantheon-systems/terminus-github-actions@v1 | ||
| with: | ||
| pantheon-machine-token: ${{ secrets.PANTHEON_MACHINE_TOKEN }} | ||
| run: | | ||
| sudo apt update | ||
| sudo apt install -y curl php-common php-cli php-xml php-mbstring php-curl git jq | ||
| php -r "copy('https://getcomposer.org/installer', 'composer-setup.php');" | ||
| php -r "if (hash_file('sha384', 'composer-setup.php') === file_get_contents('https://composer.github.io/installer.sig')) { echo 'Installer verified'.PHP_EOL; } else { echo 'Installer corrupt'.PHP_EOL; unlink('composer-setup.php'); exit(1); }" | ||
| php composer-setup.php | ||
| php -r "unlink('composer-setup.php');" | ||
| mv composer.phar /usr/local/bin/composer | ||
| export ASSET_ID="$(curl -sL -H 'Accept: application/vnd.github+json' -H 'X-GitHub-Api-Version: 2022-11-28' https://api.github.com/repos/vfalconisumo/sumo-terminus/releases | jq -r '.[0].assets[0].id')" | ||
| curl -sL -H "Accept: application/octet-stream" -H "X-GitHub-Api-Version: 2022-11-28" -o terminus "https://api.github.com/repos/vfalconisumo/sumo-terminus/releases/assets/$ASSET_ID" | ||
| chmod +x terminus | ||
| mv terminus /usr/local/bin/terminus | ||
| terminus self:update |
There was a problem hiding this comment.
I have concerns about replacing this with a fork in a personal repository.
Why is it necessary?
Can it be avoided?
What will be the ongoing maintenance burden?
If these questions are already documented, please link the document in the PR.
If a fork cannot be avoided, it should be done under the SumoLogic org.
There was a problem hiding this comment.
The fork from my personal Sumo account is necessary because the command we are using, local:commitAndPush, successfully commits and pushes the changes to Pantheon, but that command throws a type error in the upstream because the function expects to return a string but in reality returns a void. That error causes the workflow to show as failing even though it is successful.
The maintenance burden falls on my team, and our plan is to use this fork until we can get Pantheon to merge a fix for it upstream.
I am happy to transfer it to an org, but my team's repos live in sanyaku not SumoLogic, so I'm unclear on which org is correct here.
There was a problem hiding this comment.
Makes sense. Upstream does look buggy for that function. Do we have an issue filed with them?
Sanyaku is an org that is holding private repositories. Since this is intended to be public, let's fork it in the SumoLogic org, which is meant for public repositories, and add a comment to its readme about why we forked, with a link to the upstream issue.
There was a problem hiding this comment.
Yep, opening the PR with them after we complete this migration.
Should I ask IT for the repo in the sumologic org, or does a different team handle its admin?
There was a problem hiding this comment.
Yes, IT is probably the best way to go about adding a repo to the SumoLogic org. Thanks!
Purpose of this pull request
This pull request updates the Pantheon deployment workflow to add support for Marketing's automation. It will run parallel with the current AWS deployment workflow.
The required vars and secrets have been updated in the repo config.
Select the type of change
Ticket (if applicable)
https://app.asana.com/1/144190854636/project/1210702047641089/task/1210906483540147