Conversation
- Update start_all_servers.py to use start_new_session=True on Unix for proper process group management (was using Windows-only creationflags) - Add error handling for process termination edge cases - Update Claude Code hooks to use relative paths instead of absolute Windows paths, enabling cross-platform compatibility Both changes maintain backwards compatibility with Windows. Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <[email protected]> Co-Authored-By: Happy <[email protected]>
- Update test_auth_flow.py to use pathlib.Path for sys.path insertion - Removes hardcoded C:\Users\... path that broke Linux compatibility Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <[email protected]> Co-Authored-By: Happy <[email protected]>
Define project conventions, directory structure, commit message format, and cross-platform development guidelines.
- Convert maintenance mode to use asyncio.Lock instead of threading.Lock to prevent blocking the event loop in async handlers (system.py) - Add newline='' to StringIO in CSV export for consistent line endings across platforms (dsar_processor.py) - Document threading.Lock usage in DNSPinStore with recommendation for Redis-backed storage in multi-process deployments (protocol.py)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pathlib.Pathasyncio.Lockto prevent event loop blockingChanges
forge/api/routes/system.pyasyncio.Lockinstead ofthreading.Lockfor async handlersforge/compliance/privacy/dsar_processor.pynewline=''to StringIO for consistent CSV line endingsforge/federation/protocol.pyforge/services/hook_service.pyforge/services/process_service.pyTest plan
🤖 Generated with Claude Code